-
Notifications
You must be signed in to change notification settings - Fork 3k
Generate documentation file for config group #5044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gsmet
merged 3 commits into
quarkusio:master
from
machi1990:docs/remove-usage-of-inexistant-generated-doc-file
Nov 3, 2019
Merged
Generate documentation file for config group #5044
gsmet
merged 3 commits into
quarkusio:master
from
machi1990:docs/remove-usage-of-inexistant-generated-doc-file
Nov 3, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machi1990
commented
Oct 30, 2019
5fee56b
to
91a0fb2
Compare
@gsmet I have added a commit which enable the generation of config group as discussed above. |
8165bd6
to
c6ec3fb
Compare
The file can be included via \include::{generated-dir}/config/quarkus-your-extension-dashed-config-group-simple-name.adoc[opts=optional, leveloffset=+1]
c6ec3fb
to
5ab8513
Compare
gsmet
approved these changes
Nov 3, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the output and everything looks in order. We can tune it later if needed.
machi1990
added a commit
to machi1990/quarkus
that referenced
this pull request
Nov 23, 2019
… items (non config group Fixes quarkusio#5144 Follows up quarkusio#5044
machi1990
added a commit
to machi1990/quarkus
that referenced
this pull request
Nov 24, 2019
… items (non config group Fixes quarkusio#5144 Follows up quarkusio#5044
mmusgrov
pushed a commit
to mmusgrov/quarkus
that referenced
this pull request
Dec 13, 2019
… items (non config group Fixes quarkusio#5144 Follows up quarkusio#5044
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1st commit:
Make it possible to generate a file par config group.
2nd commit:
use the generated file for
FormAuthConfig
to avoid the usage of an inexistant file which was generating the following warning3rd commit:
Resolves #5097