Check for invalid characters when adding an extension

[nderwin]

• Fixes Quarkus CLI does not check for special characters when adding an extension #49895
• use a pattern matcher to validate the groupId and artifactId for a fully qualified extension name (group, artifact, and version)

Signed-off-by:Nathan Erwin [email protected]

[nderwin]

I'm not sure I'm fully happy with this as it still can lead to bad dependencies being added because when given a GAV, it just adds it, and you'll find out it's bad with your first Maven command.

Regardless, some testing scenarios...

java -jar quarkus-cli-999-SNAPSHOT-runner.jar ext add io.quarkiverse.businessscore:quarkus-business-score-health~:1.0.0.Alpha4
[ERROR] ❗  Nothing installed because keyword(s) 'io.quarkiverse.businessscore:quarkus-business-score-health~:1.0.0.Alpha4' were not matched in the catalog.

Note an invalid dependency, but it has valid characters in it:

java -jar quarkus-cli-999-SNAPSHOT-runner.jar ext add io.quarkus:quarkus-info-:3.20.1
[SUCCESS] ✅  Extension io.quarkus:quarkus-info-:3.20.1 has been installed

Note a really invalid dependency:

java -jar quarkus-cli-999-SNAPSHOT-runner.jar ext add group:artifact:version
[SUCCESS] ✅  Extension group:artifact:version has been installed

If you leave off the version, then the dependency is validated against the catalog, so it would have given an error for adding 'io.quarkiverse.businessscore:quarkus-business-score-health~

[gsmet]

I haven't checked the code but is there a reason why we don't send an explicit error?

[gsmet]

Thanks for having a look at this one btw :)

[nderwin]

I haven't checked the code but is there a reason why we don't send an explicit error?

Yeah, that would be nicer, right? Unfortunately, it goes back to ExtensionInstallPlan - it has a provision for just a collection of unmatched keys, no collection of errors.

I stopped short of adding that as it touches many more classes, but if you think it's worth it, I can take a look at that.

[nderwin]

@gsmet Meh, it was easier than I thought, so I just went ahead and added it. Example now:

java -jar quarkus-cli-999-SNAPSHOT-runner.jar ext add io.quarkiverse.businessscore:quarkus-business-score-health~:1.0.0.Alpha4
[FAILURE] ❌  Nothing installed because keyword(s) 'io.quarkiverse.businessscore:quarkus-business-score-health~:1.0.0.Alpha4' were invalid.

[gastaldi]

Can you include some tests to justify the change?

[nderwin]

Can you include some tests to justify the change?

Sure, just as soon as I figure out where to put 'em.

[nderwin]

Ok @gastaldi I took a swipe at adding tests, maybe it's ok? Not really sure...

[gastaldi]

LGTM, thanks!

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 39f9848.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

---

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/smallrye-reactive-messaging/deployment

❌ io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector - History

• Expecting actual: ["-4","-5","-6","-7","-8","-9","-10","-11"] to start with: ["-3", "-4", "-5", "-6"] - java.lang.AssertionError

java.lang.AssertionError: 

Expecting actual:
  ["-4","-5","-6","-7","-8","-9","-10","-11"]
to start with:
  ["-3", "-4", "-5", "-6"]

	at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:36)

---

⚙️ JVM Tests - JDK 21

📦 extensions/infinispan-cache/deployment

❌ io.quarkus.cache.infinispan.InfinispanCacheTest.testGetAsyncWithParallelCalls - History

• expected: "thread1" but was: "thread2" - org.opentest4j.AssertionFailedError

org.opentest4j.AssertionFailedError: 

expected: "thread1"
 but was: "thread2"
	at io.quarkus.cache.infinispan.InfinispanCacheTest.testGetAsyncWithParallelCalls(InfinispanCacheTest.java:285)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:534)
	at io.quarkus.test.QuarkusUnitTest.interceptTestMethod(QuarkusUnitTest.java:448)

---

⚙️ JVM Tests - JDK 25

📦 extensions/smallrye-graphql/deployment

❌ io.quarkus.smallrye.graphql.deployment.CompletionStageTest.testSourcePost - History

• 1 expectation failed. Expected status code <200> but was <500>. - java.lang.AssertionError

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:483)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:73)