-
Notifications
You must be signed in to change notification settings - Fork 3k
Modify @RequestParam presence handling #50400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify @RequestParam presence handling #50400
Conversation
This comment has been minimized.
This comment has been minimized.
3ba49c8
to
5c2cd40
Compare
Could you please take a look @geoand when you have some time? |
This comment has been minimized.
This comment has been minimized.
It would be nice to have a test for this |
5c2cd40
to
f2fbe42
Compare
|
This comment has been minimized.
This comment has been minimized.
Thanks for the test! Unfortunately, the test is not specific enough, meaning that when someone comes back to this commit in the future, it will be very hard to understand why the test actually tests the requested feature. |
f2fbe42
to
ef996a0
Compare
How about now? |
Much better! Can we also have a test that shows the use of |
Status for workflow
|
This one was already in here |
👌 |
thx |
Fixes #50321
Validate presence of parameters during the RESOLVE_METHOD_PARAMETERS and, if absent, throw exception to stop execution