Skip to content

Conversation

maxandersen
Copy link
Member

jaeger was being listed via listExtensions.

With this fix any extension with a "unlisted" key in metadata gets unlisted.
i.e. the mere presence of the key makes it unlisted.

@maxandersen
Copy link
Member Author

@emmanuelbernard can you just confirm listExtensions should always hide "unlisted" extensions ?
addExtension will actually still work and wondering if should remove extensions completely even in add.

@emmanuelbernard
Copy link
Member

listExtension should always excluded the unlisted ones yes.
Likewise partial hit via addExtensions should exclude unlisted.
For a perfect GAV, we should not exclude.

}

private boolean filterUnlisted(Extension e) {
return !e.getMetadata().containsKey("unlisted");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and value true I guess.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just that technically i can be both true (boolean) or a string 'true'. but sure let me add that together while making add honor it too.

Copy link
Member

@aloubyansky aloubyansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Emmanuel's remark. Let's check for the value of unlisted.

jaeger was being listed via listExtensions.

With this fix any extension with a "unlisted" key in metadata gets unlisted.
i.e. the mere presence of the key makes it unlisted.
@maxandersen
Copy link
Member Author

I've updated to have check be explicit for "true" or true and addExtension now ignores unlisted unless there is an exact match on artifactId (it never took into account groupid - something we probably want to fix/cleanup in future).

@maxandersen maxandersen merged commit 633791f into quarkusio:master Oct 31, 2019
@gsmet gsmet added this to the 0.28.0 milestone Oct 31, 2019
@gsmet gsmet changed the title unlist unlisted in listextensions Unlist unlisted in list-extensions Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants