Skip to content

Conversation

loicmathieu
Copy link
Contributor

Fix a small documentation error.

Add a reference to the Java 8 modules that Quarkus automatically add in the rest json guide.


----
quarkus.log.category."io.quarkus.arc.producer".level=DEBUG
quarkus.log.category."io.quarkus.arc.processor".level=DEBUG
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkouba can you check it's correct?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is not correct. For application.properties file can only be used for run time configuration of logging and beans are removed during build. So the only way to show the debug messages is to configure the build tool used, i.e. Maven through mvn -X and grep "Removed unused".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkouba it works in dev mode (I used it) as the build is done at runtime.
I propose to change it this way:

When using the dev mode (running `mvn clean compile quarkus:dev`), you can see more information about which beans are being removed 
by enabling additional logging via the following line in your `application.properties`.

-Dextensions="resteasy-jackson"
----

To improve user experience, Quarkus registers the three Jackson https://github.com/FasterXML/jackson-modules-java8[Java 8 modules] so you don't need to do it manually.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, this change looks good to me so I'm just waiting for Martin's approval.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, first time I wrote a document sentence without any correction needed !
I must have improve my english :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean "improved"? :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was about to make the same joke :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a work in progress ...

@gsmet gsmet added this to the 0.28.0 milestone Oct 30, 2019
mkouba
mkouba previously requested changes Oct 31, 2019
Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls fix the logging info in cdi-reference.adoc.

@loicmathieu loicmathieu force-pushed the doc/jackson-and-correction branch from b64d0bc to 3fcadf7 Compare October 31, 2019 09:18
@gsmet
Copy link
Member

gsmet commented Oct 31, 2019

@loicmathieu can you squash the last commit, please? Let's try to have semantic commits. Thanks!

@loicmathieu loicmathieu force-pushed the doc/jackson-and-correction branch from 3fcadf7 to f91333c Compare October 31, 2019 12:38
@loicmathieu
Copy link
Contributor Author

@gsmet done

@gsmet gsmet dismissed mkouba’s stale review October 31, 2019 17:32

Comments addressed

@gsmet gsmet merged commit 6f941ec into quarkusio:master Oct 31, 2019
@gsmet
Copy link
Member

gsmet commented Oct 31, 2019

Merged, thanks!

@loicmathieu loicmathieu deleted the doc/jackson-and-correction branch November 5, 2019 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants