-
Notifications
You must be signed in to change notification settings - Fork 3k
Documentation : Jackson Java 8 modules and a small correction #5035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation : Jackson Java 8 modules and a small correction #5035
Conversation
|
|
||
| ---- | ||
| quarkus.log.category."io.quarkus.arc.producer".level=DEBUG | ||
| quarkus.log.category."io.quarkus.arc.processor".level=DEBUG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mkouba can you check it's correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or @manovotn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this is not correct. For application.properties file can only be used for run time configuration of logging and beans are removed during build. So the only way to show the debug messages is to configure the build tool used, i.e. Maven through mvn -X and grep "Removed unused".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mkouba it works in dev mode (I used it) as the build is done at runtime.
I propose to change it this way:
When using the dev mode (running `mvn clean compile quarkus:dev`), you can see more information about which beans are being removed
by enabling additional logging via the following line in your `application.properties`.
| -Dextensions="resteasy-jackson" | ||
| ---- | ||
|
|
||
| To improve user experience, Quarkus registers the three Jackson https://github.com/FasterXML/jackson-modules-java8[Java 8 modules] so you don't need to do it manually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the record, this change looks good to me so I'm just waiting for Martin's approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, first time I wrote a document sentence without any correction needed !
I must have improve my english :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean "improved"? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was about to make the same joke :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a work in progress ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls fix the logging info in cdi-reference.adoc.
b64d0bc to
3fcadf7
Compare
|
@loicmathieu can you squash the last commit, please? Let's try to have semantic commits. Thanks! |
Also fixes a missing backtick in the extension author guide.
3fcadf7 to
f91333c
Compare
|
@gsmet done |
|
Merged, thanks! |
Fix a small documentation error.
Add a reference to the Java 8 modules that Quarkus automatically add in the rest json guide.