Skip to content

Conversation

akshakp
Copy link
Contributor

@akshakp akshakp commented Oct 30, 2019

Updated typos for Openshift spelling under Openshift support section

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's get the case right while we're at it :).

Can you apply my suggestions and squash everything?

----

The Openshfit resources can be customized in a similar approach with kubernetes.
The Openshift resources can be customized in a similar approach with kubernetes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The Openshift resources can be customized in a similar approach with kubernetes.
The OpenShift resources can be customized in a similar approach with kubernetes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gsmet . Added the suggestions :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you forgot this one? And can you squash everything in a single commit? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gsmet updated most of the case references. Please confirm :)

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I squashed your commits into one and will merge.

Thanks!

@gsmet gsmet merged commit f2ee9a2 into quarkusio:master Oct 30, 2019
@gsmet gsmet added this to the 0.28.0 milestone Oct 30, 2019
@akshakp akshakp deleted the patch-2 branch October 30, 2019 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants