Config - Avoid producing duplicate GeneratedClassBuildItem #50278

gsmet · 2025-09-25T08:35:05Z

Also guard against it in the Jar generation to make sure we don't end up with duplicate entries.

gsmet · 2025-09-25T08:35:29Z

@radcortez I would appreciate if you could prioritize the review as we need the fix in 3.28.2.

radcortez · 2025-09-25T09:03:15Z

The check seems to be failing with other generated classes.

github-actions · 2025-09-25T09:15:42Z

🎊 PR Preview 0075acc has been successfully built and deployed to https://quarkus-pr-main-50278-preview.surge.sh/version/main/guides/

Images of blog posts older than 3 months are not available.
Newsletters older than 3 months are not available.

gsmet · 2025-09-25T09:24:45Z

The check seems to be failing with other generated classes.

I'll have a look once I get a full CI report.

snazy

Thanks for the quick fix :)

snazy · 2025-09-25T10:17:17Z

extensions/arc/deployment/src/main/java/io/quarkus/arc/deployment/ConfigBuildStep.java

            BuildProducer<AdditionalConstrainedClassBuildItem> additionalConstrainedClasses) {

-        processConfigClasses(combinedIndex, generatedClasses, reflectiveClasses, reflectiveMethods, configClasses,
+        Map<String, GeneratedClassBuildItem> generatedConfigClasses = new HashMap<>();


(Not very familiar with the code-generation code, so ignore my comment, if it doesn't apply)

Should this be a LinkedHashMap for reproducibility?

The elements are sorted when necessary i.e. later when assembling the jar.

Build steps are generating classes in parallel so the list is not really ordered.

snazy · 2025-09-25T10:17:23Z

core/deployment/src/main/java/io/quarkus/deployment/steps/ConfigGenerationBuildStep.java

            BuildProducer<AdditionalConstrainedClassBuildItem> additionalConstrainedClasses) {

-        processConfigMapping(combinedIndex, generatedClasses, reflectiveClasses, reflectiveMethods, configClasses,
+        Map<String, GeneratedClassBuildItem> generatedConfigClasses = new HashMap<>();


(Not very familiar with the code-generation code, so ignore my comment, if it doesn't apply)

Should this be a LinkedHashMap for reproducibility?

snazy · 2025-09-25T10:17:40Z

core/deployment/src/main/java/io/quarkus/deployment/configuration/ConfigMappingUtils.java

            byte[] classBytes = mappingMetadata.getClassBytes();
-            generatedClasses.produce(new GeneratedClassBuildItem(isApplicationClass, mappingMetadata.getClassName(),
-                    classBytes));
+            generatedConfigClasses.put(mappingMetadata.getClassName(),


Wonder if it's sufficient to check for generatedConfigClasses.put() != null instead of doing a Stream.sorted().count() in AbstractJarBuilder.

I want the full list of problematic classes, otherwise it makes fixing issues very annoying.

Also guard against it in the Jar generation to make sure we don't end up with duplicate entries. Fixes quarkusio#50265

… multiple interfaces

quarkus-bot · 2025-09-25T17:17:34Z

Status for workflow `Quarkus Documentation CI`

This is the status report for running Quarkus Documentation CI on commit fc8f1fd.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

quarkus-bot · 2025-09-25T20:51:07Z

Status for workflow `Quarkus CI`

This is the status report for running Quarkus CI on commit fc8f1fd.

Failing Jobs

Status	Name	Step	Failures	Logs	Raw logs	Build scan
❌	Gradle Tests - JDK 17	`Build`	Failures	Logs	Raw logs	🔍
✔️	Gradle Tests - JDK 17 Windows			Logs	Raw logs	🚧

Full information is available in the Build summary check run.
You can consult the Develocity build scans.

Failures

⚙️ Gradle Tests - JDK 17 #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

❌ io.quarkus.gradle.TestFixturesClientExceptionMapperTest.testBasicMultiModuleBuild line 12 - History - More details - Source on GitHub

java.lang.AssertionError: Gradle build failed with exit code 1
	at io.quarkus.gradle.QuarkusGradleWrapperTestBase.runGradleWrapper(QuarkusGradleWrapperTestBase.java:173)
	at io.quarkus.gradle.QuarkusGradleWrapperTestBase.runGradleWrapper(QuarkusGradleWrapperTestBase.java:87)
	at io.quarkus.gradle.QuarkusGradleWrapperTestBase.runGradleWrapper(QuarkusGradleWrapperTestBase.java:82)
	at io.quarkus.gradle.TestFixturesClientExceptionMapperTest.testBasicMultiModuleBuild(TestFixturesClientExceptionMapperTest.java:12)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

📦 integration-tests/gradle/target/classes/test-fixtures-client-exception-mapper

❌ org.example.MyRemoteServiceTest.testGetExtensionsById() - History - More details - Source on GitHub

jakarta.ws.rs.ProcessingException: io.netty.channel.ConnectTimeoutException: connection timed out after 15000 ms: stage.code.quarkus.io/44.199.152.74:443
	at org.jboss.resteasy.reactive.client.handlers.ClientSendRequestHandler$2.accept(ClientSendRequestHandler.java:235)
	at org.jboss.resteasy.reactive.client.handlers.ClientSendRequestHandler$2.accept(ClientSendRequestHandler.java:227)
	at io.smallrye.context.impl.wrappers.SlowContextualConsumer.accept(SlowContextualConsumer.java:21)
	at io.smallrye.mutiny.helpers.UniCallbackSubscriber.onFailure(UniCallbackSubscriber.java:62)
	at io.smallrye.mutiny.operators.uni.UniOperatorProcessor.onFailure(UniOperatorProcessor.java:55)
	at org.jboss.resteasy.reactive.client.AsyncResultUni.lambda$subscribe$1(AsyncResultUni.java:37)
	at io.vertx.core.impl.future.FutureImpl$4.onFailure(FutureImpl.java:188)

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 test-framework/jacoco/runtime

❌ io.quarkus.jacoco.runtime.DataFileWatchTest.waitForDataFileThatNeverAppears - History

Expecting value to be false but was true - org.opentest4j.AssertionFailedError

org.opentest4j.AssertionFailedError: 

Expecting value to be false but was true
	at io.quarkus.jacoco.runtime.DataFileWatchTest.waitForDataFileThatNeverAppears(DataFileWatchTest.java:208)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

⚙️ JVM Tests - JDK 21

📦 extensions/smallrye-openapi/deployment

❌ io.quarkus.smallrye.openapi.test.vertx.OpenApiHttpRootPathCorsTestCase.testCorsFilterProperties - History

1 expectation failed. Expected status code <200> but was <500>. - java.lang.AssertionError

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:73)

⚙️ Maven Tests - JDK 17 Windows

📦 integration-tests/devmode

❌ io.quarkus.test.devui.DevUIGrpcSmokeTest.testTestService - History

Too many recursions, message not returned for id [123205416] - java.lang.RuntimeException

java.lang.RuntimeException: Too many recursions, message not returned for id [123205416]
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:175)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:178)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:178)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:178)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:178)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:178)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:178)

⚙️ Gradle Tests - JDK 17 Windows

📦 integration-tests/gradle

❌ io.quarkus.gradle.TestFixturesClientExceptionMapperTest.testBasicMultiModuleBuild - History

Gradle build failed with exit code 1 - java.lang.AssertionError

java.lang.AssertionError: Gradle build failed with exit code 1
	at io.quarkus.gradle.QuarkusGradleWrapperTestBase.runGradleWrapper(QuarkusGradleWrapperTestBase.java:173)
	at io.quarkus.gradle.QuarkusGradleWrapperTestBase.runGradleWrapper(QuarkusGradleWrapperTestBase.java:87)
	at io.quarkus.gradle.QuarkusGradleWrapperTestBase.runGradleWrapper(QuarkusGradleWrapperTestBase.java:82)
	at io.quarkus.gradle.TestFixturesClientExceptionMapperTest.testBasicMultiModuleBuild(TestFixturesClientExceptionMapperTest.java:12)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

gsmet requested a review from radcortez September 25, 2025 08:35

quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/config area/core labels Sep 25, 2025

gsmet added the triage/backport label Sep 25, 2025

gsmet mentioned this pull request Sep 25, 2025

3.28.1: java.util.zip.ZipException: duplicate entry in Quarkus generated jar(s) #50265

Closed

radcortez approved these changes Sep 25, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

snazy reviewed Sep 25, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

quarkus-bot bot added triage/flaky-test area/spring Issues relating to the Spring integration labels Sep 25, 2025

This comment has been minimized.

Sign in to view

gsmet and others added 2 commits September 25, 2025 17:41

Config - Avoid producing duplicate GeneratedClassBuildItem

7b4aa3a

Also guard against it in the Jar generation to make sure we don't end up with duplicate entries. Fixes quarkusio#50265

Avoid duplicate registration of Spring repositories when implementing…

fc8f1fd

… multiple interfaces

radcortez force-pushed the avoid-duplicates branch from ae51595 to fc8f1fd Compare September 25, 2025 16:43

gsmet merged commit c8c1f36 into quarkusio:main Sep 26, 2025
59 of 60 checks passed

quarkus-bot bot added this to the 3.29 - main milestone Sep 26, 2025

quarkus-bot bot added the kind/bugfix label Sep 26, 2025

jedla97 mentioned this pull request Sep 28, 2025

Multiple GeneratedClassBuildItem were produced for the same classes when using abstract class #50314

Closed

gsmet modified the milestones: 3.29 - main, 3.28.2 Sep 29, 2025

gsmet removed the triage/backport label Sep 29, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Config - Avoid producing duplicate GeneratedClassBuildItem #50278

Config - Avoid producing duplicate GeneratedClassBuildItem #50278

Uh oh!

gsmet commented Sep 25, 2025

Uh oh!

gsmet commented Sep 25, 2025

Uh oh!

radcortez commented Sep 25, 2025

Uh oh!

This comment has been minimized.

github-actions bot commented Sep 25, 2025 •

edited

Loading

Uh oh!

gsmet commented Sep 25, 2025

Uh oh!

snazy left a comment

Uh oh!

snazy Sep 25, 2025

Uh oh!

gsmet Sep 25, 2025 •

edited

Loading

Uh oh!

snazy Sep 25, 2025

Uh oh!

snazy Sep 25, 2025

Uh oh!

gsmet Sep 25, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

quarkus-bot bot commented Sep 25, 2025

Uh oh!

quarkus-bot bot commented Sep 25, 2025 •

edited by github-actions bot

Loading

Uh oh!

Uh oh!

Uh oh!

Config - Avoid producing duplicate GeneratedClassBuildItem #50278

Config - Avoid producing duplicate GeneratedClassBuildItem #50278

Uh oh!

Conversation

gsmet commented Sep 25, 2025

Uh oh!

gsmet commented Sep 25, 2025

Uh oh!

radcortez commented Sep 25, 2025

Uh oh!

This comment has been minimized.

github-actions bot commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gsmet commented Sep 25, 2025

Uh oh!

snazy left a comment

Choose a reason for hiding this comment

Uh oh!

snazy Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

gsmet Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

snazy Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

snazy Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

gsmet Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

quarkus-bot bot commented Sep 25, 2025

Status for workflow Quarkus Documentation CI

Uh oh!

quarkus-bot bot commented Sep 25, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Status for workflow Quarkus CI

Failing Jobs

Failures

⚙️ Gradle Tests - JDK 17 #

📦 integration-tests/gradle

📦 integration-tests/gradle/target/classes/test-fixtures-client-exception-mapper

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 test-framework/jacoco/runtime

⚙️ JVM Tests - JDK 21

📦 extensions/smallrye-openapi/deployment

⚙️ Maven Tests - JDK 17 Windows

📦 integration-tests/devmode

⚙️ Gradle Tests - JDK 17 Windows

📦 integration-tests/gradle

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Sep 25, 2025 •

edited

Loading

gsmet Sep 25, 2025 •

edited

Loading

Status for workflow `Quarkus Documentation CI`

quarkus-bot bot commented Sep 25, 2025 •

edited by github-actions bot

Loading

Status for workflow `Quarkus CI`