Skip to content

Use a boolean for unlisted in Jaeger metadata #5022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2019
Merged

Use a boolean for unlisted in Jaeger metadata #5022

merged 1 commit into from
Oct 30, 2019

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Oct 30, 2019

@ia3andy can you check if it fixes your issue?

@gsmet gsmet added this to the 0.28.0 milestone Oct 30, 2019
ia3andy
ia3andy approved these changes Oct 30, 2019
View reviewed changes
Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsmet
Copy link
Member Author

gsmet commented Oct 30, 2019

Maybe test it's OK for you? I want to be sure there's not some weird transformation messing with the boolean during the process.

@gsmet gsmet merged commit 8f307e9 into quarkusio:master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ia3andy ia3andy ia3andy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.28.0

Development

Successfully merging this pull request may close these issues.

2 participants

@gsmet @ia3andy