-
Notifications
You must be signed in to change notification settings - Fork 3k
ArC: fix NPE in InvokerGenerator #50211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ArC: fix NPE in InvokerGenerator #50211
Conversation
That should be no issue though, right? |
This comment has been minimized.
This comment has been minimized.
Well, I wouldn't call it "no issue" because whenever you use a primitive param with a type annotation on a method that is called via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although the test on several places iterates over a singleton list, which is unnecessary.
Yeah, sure. I just copied and modified one of the existing test. Feel free to jump in this PR ;-). |
- when a primitive param is annotated with a type annotation
2634cef
to
1e9dec5
Compare
Done :-) |
Status for workflow
|
Unfortunately, the only workaround I can see is to avoid using primitives and use the wrapper types instead.
Fixes #50225.