Simplify inference of the SupportedDbKind and avoid NoClassDefFoundError on CommunityDatabase
#50146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No effect on the logic, just makes the code easier to adapt.
quarkus-bot
bot
added
area/hibernate-orm
|
/cc @gsmet (hibernate-orm) |
This comment has been minimized.
This comment has been minimized.
We used to try to derive it from the dbKind string, falling back to attempting to interpret the Hibernate ORM "DB Product Name". But the "DB Product Name" can only be set in situation where *we have a dbKind string already*, so the fallback is pointless. Since the fallback also has problems (use of CommunityDatabase which is not necessarily in the classpath), we might as well remove it.
Status for workflow
|
gsmet
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second commit is the one that matters.
We used to try to derive it from the dbKind string, falling back to
attempting to interpret the Hibernate ORM "DB Product Name".
But the "DB Product Name" can only be set in situation where we have a
dbKind string already, so the fallback is pointless.
Since the fallback also has problems (use of
CommunityDatabasewhich isnot necessarily in the classpath), we might as well remove it.