Skip to content

Redis: improvements #50124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 18, 2025
Merged

Redis: improvements #50124

merged 3 commits into from
Sep 18, 2025

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented Sep 17, 2025

Fixes #32361
Fixes #49531
Fixes #49719

@Ladicek
Redis Client: improve documentation
2a3fda7
@Ladicek
Redis Client: add support for configuring cluster transactions
888444f
@Ladicek
Redis Client: improve and consolidate error handling in Redis transac…
58d7c5f 
…tions

The error handling is conceptually simple and uniform across
the blocking API and reactive API.

If the transaction block succeeds, the transaction is `EXEC`uted.
In that case, some commands may succeed and some may fail; this is
standard Redis behavior. The `TransactionResult.hasErrors()` method
indicates whether at least one command failed. The failures are
represented as `Throwable`s in the `TransactionResult` list.

If the transaction block fails, the transaction is discarded and
the exception is rethrown.

In case of the optimistic locking API, if the pre-transaction block
succeeds, the transaction is started and execution continutes
to the transaction block.

If the pre-transaction block fails, all watched keys are `UNWATCH`ed
and the exception is rethrown. In this case, the transaction is not
started and the transaction block is not executed.
@Ladicek Ladicek requested a review from cescoffier September 17, 2025 13:30
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Sep 17, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 58d7c5f.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Sep 17, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 58d7c5f.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17 Windows

📦 extensions/micrometer-opentelemetry/deployment

❌ io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod_Uni - History

  • Stream has no elements - java.lang.IllegalArgumentException
java.lang.IllegalArgumentException: Stream has no elements
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lambda$lastReading$2(MetricDataFilter.java:213)
	at java.base/java.util.Optional.orElseThrow(Optional.java:403)
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReading(MetricDataFilter.java:213)
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReadingDataPoint(MetricDataFilter.java:231)
	at io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod_Uni(MicrometerTimedInterceptorTest.java:174)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:534)

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 17, 2025 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@cescoffier cescoffier merged commit 21fb21d into quarkusio:main Sep 18, 2025
41 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.29 - main milestone Sep 18, 2025
@quarkus-bot quarkus-bot bot added kind/bugfix kind/enhancement New feature or request labels Sep 18, 2025
@Ladicek Ladicek deleted the redis-improvements branch September 18, 2025 07:39
@gsmet gsmet modified the milestones: 3.29 - main, 3.28.1 Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
area/documentation area/redis kind/bugfix kind/enhancement New feature or request triage/backport-3.27 triage/flaky-test
Projects
None yet
Milestone
3.28.1
3 participants
@Ladicek @cescoffier @gsmet