Skip to content

Conversation

jpohlmeyer
Copy link
Contributor

Fixes two Hibernate property constants that were still referring to the javax variant, leading to deprecation warnings.

@quarkus-bot quarkus-bot bot added the area/hibernate-orm Hibernate ORM label Sep 17, 2025
Copy link

quarkus-bot bot commented Sep 17, 2025

/cc @gsmet (hibernate-orm)

Copy link
Contributor

@marko-bekhta marko-bekhta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch!

Looking at ORM:
https://github.com/hibernate/hibernate-orm/blob/4fd814b6a12e419ab184bbeac868229baf87bd8c/hibernate-core/src/main/java/org/hibernate/tool/schema/spi/SchemaManagementToolCoordinator.java#L563
as the javax versions of these properties are used as fallbacks, it should be fine to make the switch in Quarkus.

Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I checked and it's already fixed for Hibernate Reactive:

if (persistenceUnitConfig.scripts().generation().createTarget().isPresent()) {
runtimeSettingsBuilder.put(AvailableSettings.JAKARTA_HBM2DDL_SCRIPTS_CREATE_TARGET,
persistenceUnitConfig.scripts().generation().createTarget().get());
}
if (persistenceUnitConfig.scripts().generation().dropTarget().isPresent()) {
runtimeSettingsBuilder.put(AvailableSettings.JAKARTA_HBM2DDL_SCRIPTS_DROP_TARGET,
persistenceUnitConfig.scripts().generation().dropTarget().get());
}

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 17, 2025
Copy link

quarkus-bot bot commented Sep 17, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 6c91a58.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@yrodiere yrodiere merged commit d511c09 into quarkusio:main Sep 17, 2025
47 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.29 - main milestone Sep 17, 2025
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 17, 2025
@gsmet gsmet modified the milestones: 3.29 - main, 3.28.1 Sep 23, 2025
@jmartisk jmartisk modified the milestones: 3.28.1, 3.27.1 Oct 15, 2025
@jmartisk jmartisk moved this to 3.27.1 in Backports for 3.27 Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/hibernate-orm Hibernate ORM

Projects

Status: 3.27.1

Development

Successfully merging this pull request may close these issues.

6 participants