Update Maven Surefire & Failsafe plugins to 3.5.4

[manofthepeace]

Fixes #50076

[github-actions]

🙈 The PR is closed and the preview is expired.

[gsmet]

Thanks a lot!

I think there's at least this one missing:

quarkus/independent-projects/parent/pom.xml

Line 40 in ee6ac67

<version.surefire.plugin>3.5.3</version.surefire.plugin>

.

I know about it because we got some Dependabot errors due to the misalignment.

Maybe we should have a script that handles this? It has been quite a pain.

[manofthepeace]

Done. Script may be a little hard as there are some cases like;

independent-projects/tools/devtools-testing/src/main/java/io/quarkus/devtools/testing/codestarts/QuarkusCodestartTesting.java
data.put(MAVEN_SUREFIRE_PLUGIN_VERSION.key(), "3.0.0-MOCK");

and this in a view places;
<surefire-plugin.version>3.0.0-MOCK</surefire-plugin.version>

The one I had missed was 3.5.3 instead of 3.5.2. I wonder if that was dependabot? Maybe it should not handle surefire if it causes mismatch?

I did another manual look and I believe it is fine now.

[quarkus-bot]

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 7350a1e.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 7350a1e.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

---

Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 test-framework/jacoco/runtime

❌ io.quarkus.jacoco.runtime.DataFileWatchTest.waitForPreexistingDataFileThatNeverChanges - History

• Expecting value to be false but was true - org.opentest4j.AssertionFailedError

org.opentest4j.AssertionFailedError: 

Expecting value to be false but was true
	at io.quarkus.jacoco.runtime.DataFileWatchTest.waitForPreexistingDataFileThatNeverChanges(DataFileWatchTest.java:241)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

---

⚙️ Gradle Tests - JDK 17 Windows

📦 integration-tests/gradle

❌ io.quarkus.gradle.devmode.IncludedKotlinBuildDevModeTest.main - History

• Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes 30 seconds. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes  30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:164)
	at io.quarkus.gradle.devmode.QuarkusDevGradleTestBase.getHttpResponse(QuarkusDevGradleTestBase.java:165)