Skip to content

Apply server.port tag to all the created Vert.x metrics #50054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2025
Merged

Apply server.port tag to all the created Vert.x metrics #50054

merged 1 commit into from
Sep 15, 2025

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Sep 15, 2025

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Sep 15, 2025

/cc @brunobat (micrometer), @ebullient (micrometer)

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Sep 15, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 683ff2a.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand requested a review from brunobat September 15, 2025 10:40
brunobat
brunobat approved these changes Sep 15, 2025
View reviewed changes
Copy link
Contributor

@brunobat brunobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really surprised this didn't break any tests...

@geoand
Copy link
Contributor Author

geoand commented Sep 15, 2025

I'm surprised no one complained about it earlier :)

@geoand geoand merged commit bcb313f into quarkusio:main Sep 15, 2025
34 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.29 - main milestone Sep 15, 2025
@geoand geoand deleted the #50040 branch September 15, 2025 10:55
@gsmet gsmet modified the milestones: 3.29 - main, 3.28.0 Sep 16, 2025
@gsmet gsmet modified the milestones: 3.28.0, 3.26.4 Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brunobat brunobat brunobat approved these changes

Assignees

No one assigned

Labels

area/metrics kind/bugfix

Projects

None yet

Milestone

3.26.4

Development

Successfully merging this pull request may close these issues.

This Gauge has been already registered "http.server.active.connections"

3 participants

@geoand @brunobat @gsmet