Skip to content

Fix broken native build of generated projects #5005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Fix broken native build of generated projects #5005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/deployment/src/main/java/io/quarkus/deployment/pkg/NativeConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ public class NativeConfig {
/**
* If full stack traces are enabled in the resulting image
*/
@ConfigItem(defaultValue = "false")
@ConfigItem(defaultValue = "true")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is definitely dark magic.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was unintentional. I must have made a mistake when creating this, or maybe it got missed in one of the many rebases.

public boolean fullStackTraces;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What bugs me a bit too is that now, the output when creating the native image is very scarce. I don't know if it's normal or not but we used to have a couple of Quarkus lines and now we have:

21:02:57,864 INFO  [org.jbo.threads] JBoss Threads version 3.0.0.Final

and that's it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will look into this


/**
Expand Down
12 changes: 7 additions & 5 deletions devtools/maven/src/main/java/io/quarkus/maven/BuildMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,11 +187,13 @@ public void execute() throws MojoExecutionException {
.setConfigDir(outputDirectory.toPath())
.setBuildSystemProperties(realProperties).build());
Artifact original = project.getArtifact();
if (result.getJar().isUberJar() && result.getJar().getOriginalArtifact() != null) {
original.setFile(result.getJar().getOriginalArtifact().toFile());
}
if (result.getJar().isUberJar()) {
projectHelper.attachArtifact(project, result.getJar().getPath().toFile(), "runner");
if (result.getJar() != null) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if the issue is the null test or the fact that result.getJar() is empty. When using XML config, it's not as we don't have the NPE so I think we need Stuart to say if it's normal or not.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ok, the NativeImageMojo does not attempt to look at the jar result.

if (result.getJar().isUberJar() && result.getJar().getOriginalArtifact() != null) {
original.setFile(result.getJar().getOriginalArtifact().toFile());
}
if (result.getJar().isUberJar()) {
projectHelper.attachArtifact(project, result.getJar().getPath().toFile(), "runner");
}
}

} catch (AppCreatorException e) {
Expand Down