Skip to content

Install appropriate Gradle wrapper in generated projects #50042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2025
Merged

Install appropriate Gradle wrapper in generated projects #50042

merged 1 commit into from
Sep 16, 2025

Conversation

aloubyansky
Copy link
Member

Fixes #49963

Includes the following changes:

  • Move platform version-specific tooling codestarts from the base codestarts to the project core codestarts (referenced from the platform metadata).
  • Adds a test making sure the bundled Gradle wrapper version matches gradle-wrapper.version POM property.
  • Bundle Gradle wrapper 8.14 in the base codestarts for backward compatibility when generating projects for versions prior 3.26.

Assuming this gets backported to 3.26, the following scenarios will work:

  • projects generated with CLI versions prior to 3.26 targeting Quarkus versions 3.26 and later will include Gradle wrapper versions used in those target Quarkus versions.
  • projects generated with CLI 3.26.4 and later targeting Quarkus versions 3.25 and older will include Gradle wrapper 8.14.

8.14 should work for reasonably old Quarkus versions. For example, 3.20 bundles Gradle wrapper 8.13 but is also compatible with 8.14 (which is supposed to be a good upgrade).

@aloubyansky
* Move platform version-specific tooling codestarts from the base to …
8defe1c 
…the project core codestarts.

* Bundle Gradle wrapper 8.14 in the base codestarts for backward
  compatibility when generating projects for version prior 3.26.
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/jbang Issues related to when using jbang.dev with Quarkus area/platform Issues related to definition and interaction with Quarkus Platform labels Sep 12, 2025
@aloubyansky aloubyansky mentioned this pull request Sep 12, 2025
Closed
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Sep 13, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 8defe1c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet merged commit 5252a7f into quarkusio:main Sep 16, 2025
110 of 111 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.29 - main milestone Sep 16, 2025
@gsmet gsmet modified the milestones: 3.29 - main, 3.28.0 Sep 16, 2025
@gsmet gsmet modified the milestones: 3.28.0, 3.26.4 Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/jbang Issues related to when using jbang.dev with Quarkus area/platform Issues related to definition and interaction with Quarkus Platform kind/bugfix triage/flaky-test
Projects
None yet
Milestone
3.26.4
Development

Successfully merging this pull request may close these issues.

CLI app created for latest LTS selects unsupported Gradle version, build fails
3 participants
@aloubyansky @gastaldi @gsmet