Skip to content

Conversation

holly-cummins
Copy link
Contributor

I've put 'work' in quotes since the tests don't pass, they just successfully reproduce #49780.

We added continuous testing tests for command mode as part of #47534, but couldn’t get them working (using a resources project in a higher level integration project).

I decided that using a nested project to run internal-style test (using ContinuousTestingUtils and DevModeTest) was not our typical pattern, so rather than try and make it work in the current structure, I'd rearrange. The command mode support is significant enough it merits a top-level integration test. A lot of the function is covered by the picocli and picocli-native module, but those modules are more focussed on exercising variations of picocli function.

I wondered about whether to delete the tests from the maven project entirely. In the end I left them in both places. It has the disadvantage of increasing build times for duplicated tests, so I’m open to arguments that I should delete the integration-tests/maven version.

I know it’s a bit weird to do a PR which just moved around a test without enabling it, but the change was big enough I wanted to keep it separate from the fix for #49780.

@quarkus-bot quarkus-bot bot added the area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure label Sep 10, 2025

This comment has been minimized.

@holly-cummins holly-cummins marked this pull request as draft September 10, 2025 12:12
@holly-cummins holly-cummins force-pushed the restructure-tests-for-continuous-testing-command-mode branch from d21a9b8 to 9a4f927 Compare September 10, 2025 12:16
@holly-cummins holly-cummins marked this pull request as ready for review September 10, 2025 12:16
…d pass, if another defect didn't stop it working
@holly-cummins holly-cummins force-pushed the restructure-tests-for-continuous-testing-command-mode branch from 9a4f927 to 6ab7f8f Compare September 10, 2025 12:29
Copy link

quarkus-bot bot commented Sep 10, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 6ab7f8f.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@aloubyansky aloubyansky merged commit fc83087 into quarkusio:main Sep 11, 2025
57 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.29 - main milestone Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants