Restructure tests so that continuous testing for main tests tests 'work' #49988
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've put 'work' in quotes since the tests don't pass, they just successfully reproduce #49780.
We added continuous testing tests for command mode as part of #47534, but couldn’t get them working (using a resources project in a higher level integration project).
I decided that using a nested project to run internal-style test (using ContinuousTestingUtils and DevModeTest) was not our typical pattern, so rather than try and make it work in the current structure, I'd rearrange. The command mode support is significant enough it merits a top-level integration test. A lot of the function is covered by the picocli and picocli-native module, but those modules are more focussed on exercising variations of picocli function.
I wondered about whether to delete the tests from the maven project entirely. In the end I left them in both places. It has the disadvantage of increasing build times for duplicated tests, so I’m open to arguments that I should delete the integration-tests/maven version.
I know it’s a bit weird to do a PR which just moved around a test without enabling it, but the change was big enough I wanted to keep it separate from the fix for #49780.