Skip to content

Conversation

bhawnapannu2701
Copy link
Contributor

Summary

Removed outdated references to Renarde in OIDC providers and web guides.

Why

These references are no longer relevant and caused confusion for readers.

Verification

Built docs locally; checked that links and sections render correctly.

@bhawnapannu2701 bhawnapannu2701 changed the title docs(oidc): remove outdated Renarde references Remove outdated Renarde references in OIDC and web guides Sep 9, 2025

This comment has been minimized.

Copy link

github-actions bot commented Sep 9, 2025

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

@geoand
Copy link
Contributor

geoand commented Sep 10, 2025

Thanks for the contribution!

Please squash the commits when done

@bhawnapannu2701
Copy link
Contributor Author

“Hi, I’ve checked — the commits are already squashed into a single one after applying the suggestion. Please let me know if any further change is needed"

@geoand
Copy link
Contributor

geoand commented Sep 10, 2025

Screenshot from 2025-09-10 13-57-34

begs to differ :)

@geoand geoand requested a review from sberyozkin September 10, 2025 11:01
@geoand
Copy link
Contributor

geoand commented Sep 10, 2025

Thanks for the update!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@sberyozkin
Copy link
Member

sberyozkin commented Sep 10, 2025

Thanks @bhawnapannu2701 for reverting the merge from main, if you'd like, we can help with squashing ?

Like I said, just do

git log --abbrev-commit
git rebase -i <commit-before-your-commit>

where commit-before-your-commit is one preceeding your ae7e892824f36cf98de0d1824105fde5efe1c1c8.

and this will show 2 commits with pick, your one and the one related to the suggestion I made, and you replace pick with f for this suggestion's commit.

So, say, in vi, you'll see:

pick ae7e892 ...
pick 23f1d3e ...

and you update it like this:

pick ae7e892 ...
f 23f1d3e ...

and save and it is done...

Give it a try and if it does not work, we can squash

This comment has been minimized.

@bhawnapannu2701
Copy link
Contributor Author

Squash done. Branch rebased on main. Ready for review ✅

Copy link

quarkus-bot bot commented Sep 10, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit f5dca62.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@sberyozkin sberyozkin self-requested a review September 10, 2025 22:44
Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR, thanks @bhawnapannu2701

@sberyozkin sberyozkin merged commit 8a6a2c8 into quarkusio:main Sep 10, 2025
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.29 - main milestone Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants