Skip to content

Include suggestions on what to customize when migrating to own FormatMappers #49936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2025
Merged

Include suggestions on what to customize when migrating to own FormatMappers #49936

merged 1 commit into from
Sep 17, 2025
+16 −6

Conversation

marko-bekhta
Copy link
Contributor

To give the user an idea what should be applied to their custom mappers in a FormatMappers if they want to match the config of what a built-in FormatMappers was providing.

@quarkus-bot quarkus-bot bot added the area/hibernate-orm Hibernate ORM label Sep 8, 2025
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Sep 8, 2025

/cc @gsmet (hibernate-orm)

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
yrodiere
yrodiere reviewed Sep 15, 2025
View reviewed changes
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

I think we'd better ask @gsmet for his opinion since he requested this in the first place, but here are a few comments...

@marko-bekhta marko-bekhta force-pushed the fix/update-json-formatter-check-messages branch from dcf4d0a to 44f407f Compare September 15, 2025 10:22
@marko-bekhta marko-bekhta force-pushed the fix/update-json-formatter-check-messages branch from 44f407f to 4f0372f Compare September 15, 2025 10:23
@marko-bekhta
Copy link
Contributor Author

thanks 🙂
applied your suggestions and rebased, let's wait for Guillaume 😃 👍🏻

@yrodiere yrodiere requested a review from gsmet September 15, 2025 10:26
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Sep 15, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 4f0372f.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet merged commit aa1367f into quarkusio:main Sep 17, 2025
47 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.29 - main milestone Sep 17, 2025
@gsmet gsmet modified the milestones: 3.29 - main, 3.28.1 Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrodiere yrodiere yrodiere left review comments

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/hibernate-orm Hibernate ORM triage/backport-3.27
Projects
None yet
Milestone
3.28.1
Development

Successfully merging this pull request may close these issues.
3 participants
@marko-bekhta @yrodiere @gsmet