Clone POM model before modifying it #49888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/devtools
turing85
reviewed
Sep 4, 2025
| @@ -110,8 +110,11 @@ static void setProjectModels(QuarkusBootstrapMojo mojo, BootstrapMavenContextCon | |||
| * @return raw POM | |||
| */ | |||
| private static Model getRawModel(MavenProject mp) { | |||
| final Model model = mp.getOriginalModel(); | |||
| Model model = mp.getOriginalModel(); | |||
There was a problem hiding this comment.
Why not clone the model unconditionally? Isn't here an unconditional modification in line 125?
There was a problem hiding this comment.
We don't want to deep clone unless there is a good reason to do that.
IIRC, the point of that POM file set was not to override another path but to make sure there is a POM file associated with a raw model.
To perfectly isolate the original model, we could clone it unconditionally - true.
Status for workflow
|
gsmet
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49297