Skip to content

Make const public in descriptor and add new consts #4985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2019
Merged

Make const public in descriptor and add new consts #4985

merged 1 commit into from
Oct 29, 2019

Conversation

ia3andy
Copy link
Contributor

@ia3andy ia3andy commented Oct 29, 2019

  • added in Extension: MD_STATUS
  • added in Category: MD_PINNED

@ia3andy ia3andy requested a review from maxandersen October 29, 2019 12:17
@ia3andy
Copy link
Contributor Author

ia3andy commented Oct 29, 2019

@maxandersen it shouldn't affect anything, this is for me to use from Code Quarkus ;-)

maxandersen
maxandersen approved these changes Oct 29, 2019
View reviewed changes
Copy link
Member

@maxandersen maxandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Bonus point next time to add docs to new values ;)

@gsmet gsmet added this to the 0.27.0 milestone Oct 29, 2019
@gsmet
Copy link
Member

gsmet commented Oct 29, 2019

OK, doc is failing due to an unrelated issue. Otherwise first Java build is OK and I can live with that.

@gsmet gsmet merged commit 1c8ed9b into quarkusio:master Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxandersen maxandersen maxandersen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.27.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ia3andy @gsmet @maxandersen