Make rest-client aware of deployment profiles

[geoand]

Fixes: #4983

[geoand]

@cescoffier @kenfinnigan given that the only proper way to test this is to add a test that includes %test.... and %prod.... in application.properties and invoke the project via mvn and java and the fact that those tests are slow hard to maintain, would you like me to add it or not?

[gsmet]

Stupid question: we don't have other areas doing the same mistake? It looks like an honest one.

[geoand]

That's a great question, let me check

[geoand]

We have a lot of them unfortunately... I am not sure what we should do so close to a release...

[kenfinnigan]

Instead of tests, is there a maven plugin we can use that looks for the bad way to retrieve config and fails the build if it's present?

[kenfinnigan]

I can fix this one as part of my REST TCK work, as it needs to be rebased anyway

[geoand]

@kenfinnigan not sure, but that would fail master unfortunately because there are places where the other way of doing things is valid and is being used and some where I'm not sure. This close to release I am very hesitant to make such across the board changes

[kenfinnigan]

Wasn't suggesting now, just trying to think of a way to prevent them from being added in the future

[geoand]

@kenfinnigan yes, we will need to address that for sure

[geoand]

CI failure seems to be due to Azure infra. I'll restart the failing tests once the others finish

[kenfinnigan]

I've included this fix in the REST TCK fixes, so we could close

[geoand]

OK, closing as #4954 includes the fix this PR proposed