Set fixed file/dir permissions for zip entries when building an archive

[Eng-Fouad]

This will help to generate reproducible jars: https://reproducible-builds.org/docs/archives/#file-permissions
Besides this PR: quarkusio/quarkus-fs-util#60

[reaver585]

Should we also do something similar in io.quarkus.deployment.pkg.jar.ZipFileSystemArchiveCreator?

[Eng-Fouad]

Should we also do something similar in io.quarkus.deployment.pkg.jar.ZipFileSystemArchiveCreator?

Done in quarkusio/quarkus-fs-util#60, as ZipFileSystemArchiveCreator uses io.quarkus.fs.util.ZipUtils.

[reaver585]

Done in quarkusio/quarkus-fs-util#60, as ZipFileSystemArchiveCreator uses io.quarkus.fs.util.ZipUtils.

Awesome! Thanks a lot!

[gsmet]

@Eng-Fouad what did you change in your second push?

[Eng-Fouad]

@Eng-Fouad what did you change in your second push?

Just rebasing.

[gsmet]

OK, there's no need if there's no conflict :)

Just to be sure, what happened before this patch if the original file was executable? Because I wouldn't want to change the semantic.

[Eng-Fouad]

Just to be sure, what happened before this patch if the original file was executable? Because I wouldn't want to change the semantic.

I am afraid I don't get your question.

When I was trying to test Gradle 9 with building sample Quarkus project, Gradle 9 by default was generating same JARs with no diffs. However, when I set the option useFileSystemPermissions() (which preserves file/dir permissions in the archive when copying files from file system), Gradle 9 was generating different JARs. That's why I created this PR.

#49801 (comment)

[gsmet]

@Eng-Fouad my question is: what happens if the initial file we add to the jar was executable for instance? Do we keep it executable, does it lose the executable bit? If the latter, was it the same before?

[Eng-Fouad]

@Eng-Fouad my question is: what happens if the initial file we add to the jar was executable for instance? Do we keep it executable, does it lose the executable bit? If the latter, was it the same before?

You are right. It loses the executable bit (0644). This is similar to what Gradle 9 build uses: https://github.com/gradle/gradle/pull/33598/files#diff-2fffda3c2881663429643db15f69b38523cef65f9db53504de7b8c9ce71317c4R1017

[gsmet]

Could you enable this only if the timestamp is set? This way we would only do it if people are asking for reproducible builds.

[Eng-Fouad]

Could you enable this only if the timestamp is set? This way we would only do it if people are asking for reproducible builds.

Updated the PR.

[Eng-Fouad]

Rebasing.

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 9cc2b0f.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

---

Flaky tests - Develocity

⚙️ JVM Integration Tests - JDK 17 Windows

📦 integration-tests/oidc-client-wiremock

❌ io.quarkus.it.keycloak.OidcClientTest.testEchoAndRefreshTokens - History

• 1 expectation failed. Response body doesn't match expectation. Expected: "access_token_1" Actual: access_token_2 - java.lang.AssertionError

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.
Expected: "access_token_1"
  Actual: access_token_2

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)

[gsmet]

This is great, thanks!