Emergency fix for Dev JsonRPC calls using JsonObject #49802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Phillip Kruger <[email protected]>
phillip-kruger
force-pushed
the
mcp-ext-dev-error
branch
from
adf1890 to
8966753
Compare
This comment has been minimized.
This comment has been minimized.
Status for workflow
|
| Status | Name | Step | Failures | Logs | Raw logs | Build scan |
|---|---|---|---|---|---|---|
| ❌ | JVM Integration Tests - JDK 17 | Build |
Failures | Logs | Raw logs | 🔍 |
| ✔️ | JVM Integration Tests - JDK 17 Windows | Logs | Raw logs | 🚧 | ||
| ❌ | JVM Integration Tests - JDK 21 | Build |
Failures | Logs | Raw logs | 🔍 |
Full information is available in the Build summary check run.
You can consult the Develocity build scans.
Failures
⚙️ JVM Integration Tests - JDK 17 #
- Failing: integration-tests/smallrye-config
📦 integration-tests/smallrye-config
❌ io.quarkus.it.smallrye.config.HibernatePropertiesTest. line 32 - History - More details - Source on GitHub
org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
at io.quarkus.it.smallrye.config.HibernatePropertiesTest$1.beforeAll(HibernatePropertiesTest.java:32)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
⚙️ JVM Integration Tests - JDK 21 #
- Failing: integration-tests/smallrye-config
📦 integration-tests/smallrye-config
❌ io.quarkus.it.smallrye.config.HibernatePropertiesTest. line 32 - History - More details - Source on GitHub
org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
at io.quarkus.it.smallrye.config.HibernatePropertiesTest$1.beforeAll(HibernatePropertiesTest.java:32)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
geoand
approved these changes
Sep 1, 2025
mkouba
approved these changes
Sep 1, 2025
Contributor
mkouba
left a comment
mkouba
left a comment
There was a problem hiding this comment.
I can confirm that it fixed quarkiverse/quarkus-mcp-server#389.
Contributor
|
Merging - the CI failures are unrelated and should be fixed in #49807. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix a regression in Dev UI JsonRPC that was introduced with the Dev MCP feature. This effects any runtime JsonRPC calls using JsonObject in their parameters.