Skip to content

Conversation

Eng-Fouad
Copy link
Contributor

@geoand geoand requested a review from dmlloyd August 29, 2025 14:58
@gsmet
Copy link
Member

gsmet commented Aug 29, 2025

@Eng-Fouad I pushed an additional commit to your branch to move to SmallRye Common. Could you check if it's fine for you?

This comment has been minimized.

@Eng-Fouad
Copy link
Contributor Author

@Eng-Fouad I pushed an additional commit to your branch to move to SmallRye Common. Could you check if it's fine for you?

I tested it locally and it is working as expected. Thanks.

@Eng-Fouad
Copy link
Contributor Author

There is already an API in Java for hard-linking and it works fine:

Files.createLink(link, dotEnvPath);

I think we can use it instead of the custom makeHardLinkWindowsFallback.

@Eng-Fouad Eng-Fouad changed the title Revert makeHardLinkWindowsFallback removal #48354 Falling back to hard link on Windows in linkDotEnvFile Aug 29, 2025

This comment has been minimized.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the research work!

Copy link

quarkus-bot bot commented Sep 1, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit a98ec73.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17 Windows

📦 extensions/micrometer-opentelemetry/deployment

io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod - History

  • Stream has no elements - java.lang.IllegalArgumentException
java.lang.IllegalArgumentException: Stream has no elements
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lambda$lastReading$2(MetricDataFilter.java:213)
	at java.base/java.util.Optional.orElseThrow(Optional.java:403)
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReading(MetricDataFilter.java:213)
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReadingDataPoint(MetricDataFilter.java:231)
	at io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod(MicrometerTimedInterceptorTest.java:77)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:534)

⚙️ Gradle Tests - JDK 17

📦 integration-tests/gradle

io.quarkus.gradle.BuildConfigurationTest.buildMutableJarOverride - History

  • Multiple Failures (2 failures) -- failure 1 -- [sub project 'without-configuration', package type 'mutable-jar'] Expecting path: - org.assertj.core.error.AssertJMultipleFailuresError
org.assertj.core.error.AssertJMultipleFailuresError: 

Multiple Failures (2 failures)
-- failure 1 --
[sub project 'without-configuration', package type 'mutable-jar'] 
Expecting path:
  /home/runner/_work/quarkus/quarkus/integration-tests/gradle/target/classes/build-configuration/without-configuration/build/quarkus-app/quarkus-run.jar
to exist (symbolic links were followed).
  • Multiple Failures (2 failures) -- failure 1 -- [sub project 'without-configuration', package type 'mutable-jar'] Expecting path: - org.assertj.core.error.AssertJMultipleFailuresError
org.assertj.core.error.AssertJMultipleFailuresError: 

Multiple Failures (2 failures)
-- failure 1 --
[sub project 'without-configuration', package type 'mutable-jar'] 
Expecting path:
  /home/runner/_work/quarkus/quarkus/integration-tests/gradle/target/classes/build-configuration/without-configuration/build/quarkus-app/quarkus-run.jar
to exist (symbolic links were followed).

⚙️ Gradle Tests - JDK 17 Windows

📦 integration-tests/gradle

io.quarkus.gradle.BuildConfigurationTest.buildNoOverride - History

  • Multiple Failures (1 failure) -- failure 1 -- [sub project 'without-configuration', package type 'fast-jar'] Expecting path: - org.assertj.core.error.AssertJMultipleFailuresError
org.assertj.core.error.AssertJMultipleFailuresError: 

Multiple Failures (1 failure)
-- failure 1 --
[sub project 'without-configuration', package type 'fast-jar'] 
Expecting path:
  D:\a\quarkus\quarkus\integration-tests\gradle\target\classes\build-configuration\without-configuration\build\quarkus-app\quarkus-run.jar
to exist (symbolic links were followed).

@gsmet gsmet merged commit d7ac431 into quarkusio:main Sep 2, 2025
57 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.28 - main milestone Sep 2, 2025
@gsmet gsmet modified the milestones: 3.28 - main, 3.26.2 Sep 2, 2025
@Eng-Fouad Eng-Fouad deleted the #49785 branch September 2, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev mode fails to link .env files due to missing permissions on Windows
3 participants