Add findByIds API to Panache

[mzellho]

Hibernate 7 introduced a new API to find multiple Entities by their IDs, which is not yet available in Hibernate ORM with Panache. To allow making use of it, this PR introduces a new API called findByIds (returns List<Entity>).

It also adds a similar findByIds API for MongoDB with Panache, albeit only performing a collection.find(Filters.in("_id", ids)), to avoid falling short.

[mzellho]

@gsmet can you maybe point me to how to achieve the same for Mongo, so the API is consistently available? Or maybe point me to somebody else or some resource?

Also, this PR is still a DRAFT as I definitely should also add some tests...

[geoand]

You are probably looking for

• https://github.com/quarkusio/quarkus/blob/f3fee5860b229df99463c4fd8cb4de955e55a899/extensions/panache/mongodb-panache-common/runtime/src/main/java/io/quarkus/mongodb/panache/common/runtime/MongoOperations.java
• https://github.com/quarkusio/quarkus/blob/b6f45f5e78e4c1f76b77ab7e3ab14f3a0acb79dc/extensions/panache/mongodb-panache/runtime/src/main/java/io/quarkus/mongodb/panache/PanacheMongoRepositoryBase.java

[mzellho]

@geoand thank you - I found these files, unfortunately I have zero clue about Mongo, and I could not find an API to do a findMultiple over there (or at least none that was obvious enough for me to choose). I will continue to look for a way...

[geoand]

It's possible that the Mongo driver does not have such a capability, but I don't remember off hand

[FroMage]

Great idea, thanks for the PR :)

[mzellho]

@FroMage thanks for all the feedback, I hope I didn't miss anything.

One more thing: I also found out that extensions/spring-data-jpa/runtime/src/main/java/io/quarkus/spring/data/runtime/RepositorySupport.java was already offering the same functionality by finding entities one by one based on their ID. I migrated it to use the new API and marked the second API that doesn't seem to bring any benefit to me anymore deprecated.

[FroMage]

LGTM, do you mind merging your commits before we merge this?

[FroMage]

Do you mind rebasing on the latest main too?

[FroMage]

Thanks

[FroMage]

I think the test failures are related :-/

[mzellho]

Hmmm, they were green some days ago :-( will look at it in the evening.

[github-actions]

😭 Deploy PR Preview failed.

[FroMage]

Are you ready to take this out of draft?

[FroMage]

Are you sure about this one? It appears we do findById on each ID, and then call findByIds with the results (which should be a list of entities, not ids).

[mzellho]

@FroMage this one in particular of course is incorrect and some leftover of pushing the current state of affairs before I reverted this PR to a draft. Unfortunately, there are a few problems, mainly caused by the vararg-API (some places use Iterables and calls end up in the wrong API). Also, when I last looked at it last Friday, I think I remember that on some places we have inconsistent and maybe confusing namings. I am quite busy at the moment, can only offer to continue with it in the evenings (but am absolutely willing to). But since we talk: I think it would be best to remove the vararg-API again (or give it another name) to move forward here.