Add support for generating knative manifests using the kubernetes extension. #4974
Conversation
|
Cool! |
|
I cancelled the build, we are scarce on CI resources right now. |
|
Ok, I'll ping you when everything is in place. |
|
OK, this will have to wait. Please do not push anything there today and tomorrow, we need the CI resources for the PRs that we need to get in. (sorry about that but we are struggling a bit) |
iocanel
changed the title
@gsmet: Aplogies! didn't see your message in time and I pushed. |
| KubernetesList list = Serialization.unmarshal(knativeYml.text, KubernetesList.class) | ||
| assert list != null | ||
|
|
||
| // Un-comment once: https://github.com/fabric8io/kubernetes-client/issues/1838 is addressed. |
There was a problem hiding this comment.
But this won't affect the correctness of the generated resources, correct? It's just that with the bug in the client you can't convert the yml into the domain object, right?
There was a problem hiding this comment.
Exactly! The bug only affects deserialization which is soemthing not used by the extension. Its only needed for testing.
|
@iocanel would you like to update the PR? |
|
Let's play it safe and keep this out of |
|
@geoand: The pull request just adds dependencies, docs and tests. ... famous last words |
|
@iocanel I'll tell you what: If I have some time to do some extensive testing over the weekend, we can get it in. At this point we are being very cautious so I would like to avoid any surprised :) |
|
This will need a rebase as I renamed the doc file. |
gsmet
added
the
triage/needs-rebase
|
Rebased. |
|
@iocanel does this also have to be updated to exclude the sundrio processors? |
|
Yes
…On Mon, Nov 4, 2019 at 8:41 PM Georgios Andrianakis < ***@***.***> wrote:
@iocanel <https://github.com/iocanel> does this also have to be updated
to exclude the sundrio processors?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4974?email_source=notifications&email_token=AADCEWBYWSUF4APUSNCMHCTQSBUHFA5CNFSM4JGGDXXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDAJCXY#issuecomment-549491039>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADCEWDQ4TRTSOVMH7FEXQLQSBUHFANCNFSM4JGGDXXA>
.
--
*Ioannis Canellos <http://iocanel.com>*
|
|
Yes it needs to be updated or yes it has already been updated? |
gwenneg
removed
the
triage/needs-rebase
4 participants
This pull request allows the user to generate knative manifests using the kubernetes extension.
It works in a similar manner with
Openshift, just add:The pull request includes documentation changes and an integration test.
Note: The integration test is not as thorough as the rest of the kubernetes integration tests, as its blocked by fabric8io/kubernetes-client#1838 (only affects testing).
WIP flag added until
dekorate 0.9.5reaches maven central.