-
Notifications
You must be signed in to change notification settings - Fork 3k
Fail when datasource dev service port is configured for shared network #49689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this on!
...c/main/java/io/quarkus/datasource/deployment/devservices/DevServicesDatasourceProcessor.java
Outdated
Show resolved
Hide resolved
Quarkus cannot use the port when both the application and the dev service need to start on a shared network (which happens during integration testing), so we need to make developers aware of this Closes: quarkusio#49500 Co-authored-by: Yoann Rodière <[email protected]>
👍🏽 PR updated |
Status for workflow
|
Status | Name | Step | Failures | Logs | Raw logs | Build scan |
---|---|---|---|---|---|---|
❌ | Native Tests - Windows support | Setup GraalVM |
Logs | Raw logs | 🚧 |
You can consult the Develocity build scans.
Flaky tests - Develocity
⚙️ Gradle Tests - JDK 17
📦 integration-tests/gradle
❌ io.quarkus.gradle.BuildConfigurationTest.buildUberJarOverride
- History
Multiple Failures (1 failure) -- failure 1 -- [sub project 'without-configuration', package type 'uber-jar'] Expecting path:
-org.assertj.core.error.AssertJMultipleFailuresError
org.assertj.core.error.AssertJMultipleFailuresError:
Multiple Failures (1 failure)
-- failure 1 --
[sub project 'without-configuration', package type 'uber-jar']
Expecting path:
/home/runner/_work/quarkus/quarkus/integration-tests/gradle/target/classes/build-configuration/without-configuration/build/without-configuration-1.0.0-SNAPSHOT-runner.jar
to exist (symbolic links were followed).
⚙️ Gradle Tests - JDK 17 Windows
📦 integration-tests/gradle
❌ io.quarkus.gradle.BuildConfigurationTest.buildNoOverride
- History
Multiple Failures (1 failure) -- failure 1 -- [sub project 'without-configuration', package type 'fast-jar'] Expecting path:
-org.assertj.core.error.AssertJMultipleFailuresError
org.assertj.core.error.AssertJMultipleFailuresError:
Multiple Failures (1 failure)
-- failure 1 --
[sub project 'without-configuration', package type 'fast-jar']
Expecting path:
D:\a\quarkus\quarkus\integration-tests\gradle\target\classes\build-configuration\without-configuration\build\quarkus-app\quarkus-run.jar
to exist (symbolic links were followed).
Quarkus cannot use the port when both the application
and the dev service need to start on a shared network
(which happens during integration testing), so we need
to make developers aware of this