OIDC Token Propagation: Drop deprecated @AccessToken annotation

[michalvavrik]

The io.quarkus.oidc.token.propagation.AccessToken annotation was deprecated and marked for removal in Quarkus 3.19 in the #45923, so there were 2 LTS (3.20 and 3.27), which is why I think it is safe to drop the annotation in Quarkus 3.28.

• closes io.quarkus.oidc.client.* packages are split across multiple modules #44736

[michalvavrik]

I think there is something wrong with the Initial JDK 17 Build. It happened to me in the past, I'll just wait a bit till it is in a better mood. cc @gsmet

[sberyozkin]

CC @cescoffier I agree with @michalvavrik it is OK to drop the deprecated annotation now after 2 LTSs (and corresponding product releases) but CC-ing to you just in case you think we should wait for longer

[michalvavrik]

I'll open PR for the security-openid-connect-client-quickstart QS tomorrow.

[michalvavrik]

It is really my fault, I should had done it when I deprecated the annotation, but forgot.

[michalvavrik]

See quarkusio/quarkus-quickstarts#1564.

[sberyozkin]

@michalvavrik Np at all, I could've checked the quickstart myself too when it was deprecated.

The quickstart guide in the docs does not show the deprecated one.

It is unlikely users haven't noticed they may have a deprecated annotation in their code, so we should be good to merge. I'd just like to wait a bit for Clement's input, but otherwise, given 2 main product releases have had this annotation deprecated, we should be safe to drop it

[sberyozkin]

@michalvavrik Just to double check, the current main will not be a base for 3.27 LTS ? If it is going to be a base for 3.27 then I think we should wait until 3.27 is branched

[michalvavrik]

@michalvavrik Just to double check, the current main will not be a base for 3.27 LTS ? If it is going to be a base for 3.27 then I think we should wait until 3.27 is branched

no, you can see it on my other PRs, they have tag 3.28.

[michalvavrik]

e.g. #49647

[cescoffier]

I think it's ok to drop the property. It will still require a note in the migration guide and the release notes.

[cescoffier]

Can we check the CI issue before merging?

[michalvavrik]

Can we check the CI issue before merging?

I have rebased on the current main, since the QuickStart PR is merged, the PR CI should be green now.

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit fa5fbd3.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

[michalvavrik]

Here is a proposal for the migration guide note:

The @AccessToken annotation has been permanently removed from the io.quarkus.oidc.token.propagation package. This change completes the relocation process that began in Quarkus 3.19, where the annotation was moved to io.quarkus.oidc.token.propagation.common while a temporary copy was kept in the original location for backwards compatibility. No action is required if you update your application using the Quarkus CLI, as it automatically handles this change. However, if you are not using the Quarkus CLI, you will need to manually update your imports to reflect the new package.

If someone agrees, you can add it, or wait till Sergey is back. This shouldn't be urgent.