Skip to content

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Aug 20, 2025

They are used quite a lot and they are generating extra work we can very easily avoid.

It doesn't make a HUGE difference but given it's basically free...

Before (2 differents methods called quite a lot):

Screenshot From 2025-08-20 13-18-15 Screenshot From 2025-08-20 13-00-15

After - both initialized in init:

Screenshot From 2025-08-20 13-21-43

They are used quite a lot and they are generating extra work we can
very easily avoid.

It doesn't make a HUGE difference but given it's basically free...
@gsmet gsmet requested a review from mkouba August 20, 2025 11:20
@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Aug 20, 2025
@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 20, 2025
Copy link

quarkus-bot bot commented Aug 20, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 63d55d7.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ Gradle Tests - JDK 17

📦 integration-tests/gradle

io.quarkus.gradle.BuildConfigurationTest.buildUberJarOverride - History

  • Multiple Failures (1 failure) -- failure 1 -- [sub project 'without-configuration', package type 'uber-jar'] Expecting path: - org.assertj.core.error.AssertJMultipleFailuresError
org.assertj.core.error.AssertJMultipleFailuresError: 

Multiple Failures (1 failure)
-- failure 1 --
[sub project 'without-configuration', package type 'uber-jar'] 
Expecting path:
  /home/runner/_work/quarkus/quarkus/integration-tests/gradle/target/classes/build-configuration/without-configuration/build/without-configuration-1.0.0-SNAPSHOT-runner.jar
to exist (symbolic links were followed).

⚙️ JVM Integration Tests - JDK 17

📦 integration-tests/oidc-code-flow

io.quarkus.it.keycloak.CodeFlowTest.testTokenRefresh - History

  • expected: <true> but was: <false> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at io.quarkus.it.keycloak.CodeFlowTest$3.call(CodeFlowTest.java:844)
	at io.quarkus.it.keycloak.CodeFlowTest$3.call(CodeFlowTest.java:831)
	at org.awaitility.core.CallableCondition$ConditionEvaluationWrapper.eval(CallableCondition.java:99)
	at org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:248)
	at org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:235)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)

@gsmet gsmet merged commit 2f2f155 into quarkusio:main Aug 20, 2025
57 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.28 - main milestone Aug 20, 2025
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants