Remove support for Hibernate ORM proxy generation at static init and clean up proxy generation #49591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note we also handle abstract classes more gracefully, but they've always been allowed (though the warning was not explicit about the reason).
This replaces these logs: 2025-08-18 15:25:43,530 WARN [io.qua.hib.orm.run.pro.ProxyDefinitions] (main) Could not generate an enhanced proxy for entity 'io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessInheritanceTest$MyAbstractEntity' (class='io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessInheritanceTest.MyAbstractEntity') as it's abstract. Your application might perform better if this class was non-abstract. 2025-08-18 15:25:44,075 WARN [org.hib.met.int.EntityRepresentationStrategyPojoStandard] (JPA Startup Thread) HHH000305: Could not create proxy factory for:io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessInheritanceTest$MyAbstractEntity: org.hibernate.HibernateException: Could not lookup a pre-generated proxy class definition for entity 'io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessInheritanceTest$MyAbstractEntity'. Falling back to enforced eager mode for this entity! at io.quarkus.hibernate.orm.runtime.customized.QuarkusProxyFactory.postInstantiate(QuarkusProxyFactory.java:60) [...] With these: 2025-08-18 16:03:26,754 WARN [org.hib.met.int.EntityRepresentationStrategyPojoStandard] (JPA Startup Thread) HHH000305: Could not create proxy factory for:io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessInheritanceTest$MyAbstractEntity: org.hibernate.HibernateException: Could not lookup a pre-generated proxy class definition for entity 'io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessInheritanceTest$MyAbstractEntity' (class='io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessInheritanceTest.MyAbstractEntity'): this class is abstract. Your application might perform better if this class was non-abstract. at io.quarkus.hibernate.orm.runtime.customized.QuarkusProxyFactory.postInstantiate(QuarkusProxyFactory.java:77) [...] Also, this *might* prevent unnecessary warnings in some cases if our implementation of ProxyDefinitions#needsProxyGeneration turns out to have false positives, because in that case Hibernate ORM won't requrest the proxy class on bootstrap, and thus we won't log anything.
…r 7.0 upgrade Remove some unnecessary code, and optimize a few things (e.g. avoid re-loading the HibernateProxy type for every proxy generation).
quarkus-bot
bot
added
area/hibernate-orm
|
/cc @gsmet (hibernate-orm) |
Status for workflow
|
gsmet
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best reviewed commit by commit.