Skip to content

Conversation

xstefank
Copy link
Member

Fixes #49558

@xstefank xstefank requested a review from aloubyansky August 18, 2025 11:25
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven labels Aug 18, 2025
@quarkus-bot

This comment has been minimized.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I haven't looked at the patch yet but here is a quick comment.

Comment on lines 569 to 572
List<String> changedPoms = collectChangeFilesFrom(pomFiles);
List<String> changedAdditionalFiles = collectChangeFilesFrom(additionalWatchedFiles);
if (!changedPoms.isEmpty() || !changedAdditionalFiles.isEmpty()) {
logChanges(ListUtils.union(changedPoms, changedAdditionalFiles));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not exactly excited at the idea of adding yet another dependency to a Commons jar to our own code, especially since it looks relatively simple to do without, except if I'm missing something?

Just initialize a common ArrayList collector and pass it to both methods. That's more in line with what we have elsewhere.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, I didn't introduce any new dependency :) Someone already snuck it in so I just reused :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah a lot of Commons stuff are around due to our Maven dependencies. I will spend some time adding some bans soon.

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 19, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit d268676.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Copy link
Member

@aloubyansky aloubyansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xstefank

@aloubyansky aloubyansky merged commit 48d8244 into quarkusio:main Aug 19, 2025
56 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.28 - main milestone Aug 19, 2025
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Aug 19, 2025
@aloubyansky
Copy link
Member

This could be documented

@xstefank
Copy link
Member Author

🤦 will do that asap. I will also write a blog post tomorrow.

@xstefank xstefank deleted the watchFiles-option branch August 19, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven kind/enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

As an extension developer, I would like to have the same dev mode experience as our users

3 participants