Skip to content

Conversation

@Sanne
Copy link
Member

@Sanne Sanne commented Aug 16, 2025

This attempts to limit the build executor to a size dependent on the system, with a rough attempt at ergonomics.
More importantly, it allows setting system properties in the build to fully control the sizes, allowing further experimentation.

Fixes #49574

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@dmlloyd
Copy link
Member

dmlloyd commented Aug 25, 2025

I have no idea if the sizes are right. But the code looks OK.

@geoand
Copy link
Contributor

geoand commented Aug 27, 2025

Do we have any examples showing what the behavior of a Quarkus build is pre and post this change?

@gsmet
Copy link
Member

gsmet commented Sep 3, 2025

@geoand so we might debate on the factor to number of cores but starting up to 1024 threads regardless of the number of cores seems excessive to me and I think Sanne's approach makes sense.

Now I could try to check with different values if we can agree we want to limit the number of threads.

@Sanne
Copy link
Member Author

Sanne commented Sep 5, 2025

Applied one more suggestion by @gsmet and rebased - let's merge it (if it's green)

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 5, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit b9c907e.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@Sanne
Copy link
Member Author

Sanne commented Sep 8, 2025

I need a review approval please :)

@Sanne Sanne merged commit ca6ab1c into quarkusio:main Sep 8, 2025
57 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.28 - main milestone Sep 8, 2025
@Sanne Sanne deleted the tunableBuilds branch September 8, 2025 14:57
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build Executor is creating an excessive amount of threads

4 participants