-
Notifications
You must be signed in to change notification settings - Fork 3k
Build Executor is creating an excessive amount of threads #49575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
I have no idea if the sizes are right. But the code looks OK. |
|
Do we have any examples showing what the behavior of a Quarkus build is pre and post this change? |
|
@geoand so we might debate on the factor to number of cores but starting up to 1024 threads regardless of the number of cores seems excessive to me and I think Sanne's approach makes sense. Now I could try to check with different values if we can agree we want to limit the number of threads. |
|
Applied one more suggestion by @gsmet and rebased - let's merge it (if it's green) |
Status for workflow
|
|
I need a review approval please :) |
This attempts to limit the build executor to a size dependent on the system, with a rough attempt at ergonomics.
More importantly, it allows setting system properties in the build to fully control the sizes, allowing further experimentation.
Fixes #49574