Skip to content

Undeprecate 'quarkus.otel.traces.enabled' property #49528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2025
Merged

Undeprecate 'quarkus.otel.traces.enabled' property #49528

merged 1 commit into from
Aug 19, 2025

Conversation

@mabartos
Copy link
Contributor

@mabartos mabartos commented Aug 14, 2025 •
edited
Loading

@brunobat Could you please check it? Thanks!

Would it be possible to include it into Quarkus 3.27 LTS? Thanks!

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 14, 2025

/cc @brunobat (opentelemetry), @radcortez (opentelemetry)

@mabartos
Copy link
Contributor Author

@brunobat @radcortez Any opinion on this?

I'm just worried about deadlines for the 3.27 LTS, so sorry to urge you with this :)

@gsmet
Copy link
Member

gsmet commented Aug 15, 2025

No need to worry. If it has to go in 3.26/27, it will go in them.

@gastaldi gastaldi requested a review from brunobat August 15, 2025 19:16
gastaldi
gastaldi reviewed Aug 19, 2025
View reviewed changes
...y/runtime/src/main/java/io/quarkus/opentelemetry/runtime/config/build/TracesBuildConfig.java
*/
@Deprecated
@WithDefault("true")
Optional<Boolean> enabled();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This already has a default value, shouldn't it just return boolean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whatever works for you; I'm just interested to get rid of the nasty word 'Deprecated' :P

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can see it was introduced as deprecated from the beginning: https://github.com/quarkusio/quarkus/pull/30033/files#diff-1d0492b33fd8f99c29a0be782f3a5d7402dcf8771853aec0a3cc586c81509e55R28-R30

gsmet
gsmet approved these changes Aug 19, 2025
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge this for now and we will rediscuss this with @brunobat when he's back.

@gsmet gsmet merged commit 7ae8ba7 into quarkusio:main Aug 19, 2025
2 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.28 - main milestone Aug 19, 2025
@gsmet gsmet modified the milestones: 3.28 - main, 3.26.0 Aug 19, 2025
@brunobat
Copy link
Contributor

This is fine.
I was considering this myself as well because when I added this, the OTel wiring was completely different and right now it makes more sense to keep it around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gastaldi gastaldi gastaldi left review comments

@gsmet gsmet gsmet approved these changes

@radcortez radcortez radcortez approved these changes

@brunobat brunobat Awaiting requested review from brunobat

Assignees

No one assigned

Labels

area/tracing kind/bugfix

Projects

None yet

Milestone

3.26.0

Development

Successfully merging this pull request may close these issues.

Undeprecate 'quarkus.otel.traces.enabled' property

5 participants

@mabartos @gsmet @brunobat @gastaldi @radcortez