Skip to content

After failed start make sure to read the HTTP config with the correct TCCL #4950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2019
Merged

After failed start make sure to read the HTTP config with the correct TCCL #4950

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions core/devmode/src/main/java/io/quarkus/dev/DevModeMain.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,6 @@ public void start() throws Exception {
if (context.isAbortOnFailedStart()) {
throw new RuntimeException(deploymentProblem == null ? compileProblem : deploymentProblem);
}
log.error("Failed to start Quarkus, attempting to start hot replacement endpoint to recover");
if (runtimeUpdatesProcessor != null) {
runtimeUpdatesProcessor.startupFailed();
}
}
Runtime.getRuntime().addShutdownHook(new Thread(new Runnable() {
@Override
Expand Down Expand Up @@ -180,6 +176,20 @@ public void execute(BuildContext context) {
runner.run();
DevModeMain.runner = runner;
deploymentProblem = null;

} catch (Throwable t) {
deploymentProblem = t;
if (context.isAbortOnFailedStart() || liveReload) {
log.error("Failed to start quarkus", t);
} else {
//we need to set this here, while we still have the correct TCCL
//this is so the config is still valid, and we can read HTTP config from application.properties
log.error("Failed to start Quarkus, attempting to start hot replacement endpoint to recover");
if (runtimeUpdatesProcessor != null) {
runtimeUpdatesProcessor.startupFailed();
}
}

} finally {
Thread.currentThread().setContextClassLoader(old);
}
Expand Down