-
Notifications
You must be signed in to change notification settings - Fork 3k
Provide a fluent API for CORS programmatic set up #49400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a fluent API for CORS programmatic set up #49400
Conversation
michalvavrik
commented
Aug 7, 2025
- adds CORS portion of the Provide a fluent API to set up Quarkus Security #16728 enhancement request
This comment has been minimized.
This comment has been minimized.
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
extensions/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/security/CORS.java
Outdated
Show resolved
Hide resolved
extensions/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/security/CORS.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michalvavrik Looks great, nearly ready to go
f7175df
to
54bcf7a
Compare
Thanks, I think your suggestions made sense, so I addressed them and trimmed the builder a bit. Let's see. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
extensions/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/security/CORS.java
Outdated
Show resolved
Hide resolved
extensions/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/security/HttpSecurity.java
Outdated
Show resolved
Hide resolved
extensions/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/security/HttpSecurity.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @michalvavrik, it is really close, I just like your original setup more now, with the origins(String..)
making the API non-minimalistic: Set<String>
one ensures there are no duplicates, while the array one can't guarantee it
54bcf7a
to
e117a4c
Compare
Status for workflow
|
Status for workflow
|