Skip to content

Conversation

michalvavrik
Copy link
Member

This comment has been minimized.

Copy link

github-actions bot commented Aug 7, 2025

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michalvavrik Looks great, nearly ready to go

@michalvavrik michalvavrik force-pushed the feature/fluent-api-for-cors branch from f7175df to 54bcf7a Compare August 17, 2025 16:59
@michalvavrik
Copy link
Member Author

Thanks, I think your suggestions made sense, so I addressed them and trimmed the builder a bit. Let's see.

This comment has been minimized.

This comment has been minimized.

Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @michalvavrik, it is really close, I just like your original setup more now, with the origins(String..) making the API non-minimalistic: Set<String> one ensures there are no duplicates, while the array one can't guarantee it

@michalvavrik michalvavrik force-pushed the feature/fluent-api-for-cors branch from 54bcf7a to e117a4c Compare August 17, 2025 21:38
Copy link

quarkus-bot bot commented Aug 17, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit e117a4c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Aug 18, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit e117a4c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/smallrye-reactive-messaging/deployment

io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector - History

  • Expecting actual: ["-6","-7","-8","-10","-11","-12","-13","-14"] to start with: ["-6", "-7", "-8", "-9"] - java.lang.AssertionError
java.lang.AssertionError: 

Expecting actual:
  ["-6","-7","-8","-10","-11","-12","-13","-14"]
to start with:
  ["-6", "-7", "-8", "-9"]

	at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:41)

@sberyozkin sberyozkin merged commit c31de20 into quarkusio:main Aug 18, 2025
60 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.28 - main milestone Aug 18, 2025
@michalvavrik michalvavrik deleted the feature/fluent-api-for-cors branch August 18, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants