Added anchors to configuration keys and sections #4940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmlloyd
reviewed
Oct 28, 2019
| .replaceAll("[Ŵ]", "W") | ||
| .replaceAll("[ÝŶŸ]", "Y") | ||
| .replaceAll("[ŹŽŻ]", "Z") | ||
| .replaceAll("[ß]", "ss"); |
There was a problem hiding this comment.
Yeah, I took this from a French source with years of experience dealing with I18n ;)
dmlloyd
approved these changes
Oct 28, 2019
machi1990
reviewed
Oct 28, 2019
| */ | ||
| @Override | ||
| public void format(Writer writer, List<ConfigDocItem> configDocItems) throws IOException { | ||
| public void format(Writer writer, boolean useAnchorPrefixes, List<ConfigDocItem> configDocItems) throws IOException { |
There was a problem hiding this comment.
Is there any reason we can't generate anchors all the time?
There was a problem hiding this comment.
I think we do, but they don't need a prefix if we're generating a single page.
|
CI needs some love :) |
machi1990
approved these changes
Oct 28, 2019
Might be related to the fact that |
|
Ah, I didn't think of the fact that one doc file can include two config files with the same keys. Lemme find a fix. |
Using the file name as prefix since we don't have the artifactId
FroMage
force-pushed
the
all-config-docs-anchors
branch
from
02886e4 to
31bf87b
Compare
|
Hopefully fixed, and rebased on master. Let's wait for CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @dmlloyd and @maxandersen