Keep variant info when using template locator

[ia3andy]

This fixes an issue after a change in dev-mode:
QuteSetup is clearing the templates

The template locator is then used to locate the templates with the variant, but before this fix, the variant info was lost.

This will fix: quarkiverse/quarkus-roq#587

[ia3andy]

I believe we should go one step further and keep a way to retrieve a fresh template of a template that was registered in the templates in TemplateEngine so that when cleared, we don't have to relocate..

Or instead of clearing in QuteSetup, we mark the templates as stale so that getTemplate, refreshes the content on demand?

[ia3andy]

@mkouba ping

[mkouba]

Ok, so to sum it up: when quarkus.qute.dev-mode.no-restart-templates is used in the dev mode to specify some templates for which we don't want to restart the whole app then we make sure all cached templates are removed from the engine after modification (Engine#clearTemplates()). This ensures that the latest version is loaded and used.

Now I cannot say I understand what the modification from this PR does because it looks functionally equivalent to me 🤷.

Maybe if you could add a test that would fail with the previous version then it might be easier to understand what the problem actually is.

[ia3andy]

This is not only used for no-restart-template it is also used for non path build items

[mkouba]

This is not only used for no-restart-template it is also used for non path build items

Then we actually need 2 tests ;-).

[mkouba]

I will try to add the tests early next week.

[mkouba]

I've added a test but in order to reproduce the issue I still have to clear all the loaded templates. In other words, a user should not be affected unless the quarkus.qute.dev-mode.no-restart-templates is used or Engine#clearTemplates() is called explicitly.

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 08a25c4.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.