Skip to content

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jul 31, 2025

@geoand geoand changed the title Make sure @RunOnVirtual thread on application doesn't break semantics Make sure @RunOnVirtual thread on Application doesn't break semantics Jul 31, 2025
Copy link

quarkus-bot bot commented Jul 31, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit bfcd711.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/infinispan-cache/deployment

io.quarkus.cache.infinispan.InfinispanCacheTest.testGetAsyncWithParallelCalls - History

  • expected: "thread1" but was: "thread2" - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: 

expected: "thread1"
 but was: "thread2"
	at io.quarkus.cache.infinispan.InfinispanCacheTest.testGetAsyncWithParallelCalls(InfinispanCacheTest.java:283)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:534)
	at io.quarkus.test.QuarkusUnitTest.interceptTestMethod(QuarkusUnitTest.java:448)

⚙️ JVM Integration Tests - JDK 17

📦 integration-tests/opentelemetry-grpc-only

io.quarkus.it.opentelemetry.grpc.HelloGrpcClientTest.testHello - History

  • java.lang.RuntimeException: Failed to start quarkus - java.lang.RuntimeException
java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:668)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:763)
	at java.base/java.util.Optional.orElseGet(Optional.java:364)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)

Comment on lines +897 to +899
if (blockingAnnotation != null) {
return false;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When can this condition happen?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When there is a @Blocking annotation on the method

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I had that figured out :) but you can have blocking to false but a blocking annotation around?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately yes... this whole thing needs to be rewritten (see my comment in the PR)

@gsmet gsmet merged commit 7cea083 into quarkusio:main Jul 31, 2025
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.26 - main milestone Jul 31, 2025
@gsmet gsmet modified the milestones: 3.26 - main, 3.25.1 Jul 31, 2025
@geoand geoand deleted the #49218 branch August 1, 2025 06:32
@JackyAnn
Copy link

JackyAnn commented Aug 8, 2025

The quarkus 3.25.1 version still has warning messages.

#49218 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quarkus Rest blocking method is considered non-blocking

3 participants