-
Notifications
You must be signed in to change notification settings - Fork 3k
Make sure @RunOnVirtual thread on Application
doesn't break semantics
#49246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
geoand
commented
Jul 31, 2025
- Fixes: Quarkus Rest blocking method is considered non-blocking #49218
Application
doesn't break semantics
Status for workflow
|
if (blockingAnnotation != null) { | ||
return false; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When can this condition happen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When there is a @Blocking
annotation on the method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I had that figured out :) but you can have blocking
to false but a blocking annotation around?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately yes... this whole thing needs to be rewritten (see my comment in the PR)
The quarkus 3.25.1 version still has warning messages. |