Ensure that vert.x is closed after Arc #4924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure this is proper solution, but from debugging #4834 it seems that we really need to close Vert.x after Arc, otherwise some shutdown tasks that depend on vert.x to be executed (like in the case of Kafka) can get deadlocked. |
cescoffier
approved these changes
Oct 28, 2019
|
LGTM, waiting for Stuart opinion. |
|
I don't really like this, but it will do for now. At some point I think we are going to have to revisit how we handle ordering of both startup and shutdown tasks. |
stuartwdouglas
approved these changes
Oct 28, 2019
Makes sense. The ordering that exists now is totally implicit and susceptible to these kinds of issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4834