Skip to content

Make error message about needing a DataSource for a PersistenceUnit actionable #49160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2025
Merged

Make error message about needing a DataSource for a PersistenceUnit actionable #49160

merged 1 commit into from
Jul 30, 2025

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jul 30, 2025

This is done by giving the exact configuration property that the user needs to set.

@geoand geoand requested a review from yrodiere July 30, 2025 07:36
@quarkus-bot quarkus-bot bot added the area/hibernate-orm Hibernate ORM label Jul 30, 2025
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jul 30, 2025

/cc @gsmet (hibernate-orm)

@geoand geoand mentioned this pull request Jul 30, 2025
Closed
mbellade
mbellade approved these changes Jul 30, 2025
View reviewed changes
Copy link
Member

@mbellade mbellade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @geoand

yrodiere
yrodiere approved these changes Jul 30, 2025
View reviewed changes
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! You might want to use HibernateOrmRuntimeConfig.puPropertyKey, but that's a detail.

@geoand
Make error message about needing a DS for a PU actionable
14c1eb9 
This is done by giving the exact configuration property
that the user needs to set.

Closes: quarkusio#49159
@yrodiere yrodiere added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 30, 2025
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jul 30, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 14c1eb9.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit 52c8f38 into quarkusio:main Jul 30, 2025
47 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.26 - main milestone Jul 30, 2025
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 30, 2025
@geoand geoand deleted the #49159 branch July 30, 2025 10:04
@gsmet gsmet modified the milestones: 3.26 - main, 3.25.1 Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrodiere yrodiere yrodiere approved these changes

+1 more reviewer

@mbellade mbellade mbellade approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area/hibernate-orm Hibernate ORM
Projects
None yet
Milestone
3.25.1
Development

Successfully merging this pull request may close these issues.

Hibernate initalization issue with Multiple Datasources and Compose Dev Services
4 participants
@geoand @yrodiere @mbellade @gsmet