Skip to content

Force reloadability of project dependencies in QuarkusApplicationModelTask #49117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2025
Merged

Force reloadability of project dependencies in QuarkusApplicationModelTask #49117

merged 1 commit into from
Jul 26, 2025

Conversation

reaver585
Copy link
Contributor

@reaver585 reaver585 commented Jul 26, 2025 •
edited by geoand
Loading

This new Gradle task does not have proper means for workspace discovery, so for now we optimistically setWorkspaceModule() for project dependencies.

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle labels Jul 26, 2025
@reaver585 reaver585 force-pushed the fix-tests-reloadability branch from 518a282 to c2e664d Compare July 26, 2025 12:40
reaver585
reaver585 commented Jul 26, 2025
View reviewed changes
...le-application-plugin/src/main/java/io/quarkus/gradle/tasks/QuarkusApplicationModelTask.java
final boolean isProjectDependency = resolvedDependency.getSelected()
.getId() instanceof ProjectComponentIdentifier;
if (projectModule != null || isProjectDependency) {
depBuilder.setReloadable().setWorkspaceModule();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aloubyansky please note that I added .setWorkspaceModule() here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it shouldn't be necessary. But ok, I guess.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't make it work without setting this flag - new test i added fails.
I think we need to set this flag, since it's not set elsewhere and without it, project dependency does not end up in the runtime classloader -> see 1 -> 2 -> 3

@geoand geoand requested a review from aloubyansky July 26, 2025 13:51
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@reaver585 reaver585 force-pushed the fix-tests-reloadability branch from c2e664d to 720f1f3 Compare July 26, 2025 17:16
@reaver585
Copy link
Contributor Author

@aloubyansky I had to rebase the branch, could you please re-approve?

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jul 26, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 720f1f3.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@aloubyansky
Copy link
Member

Great work @reaver585 , thanks a lot!

@aloubyansky aloubyansky merged commit 76077cb into quarkusio:main Jul 26, 2025
23 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.26 - main milestone Jul 26, 2025
@gsmet gsmet modified the milestones: 3.26 - main, 3.25.1 Jul 29, 2025
@aloubyansky aloubyansky mentioned this pull request Aug 7, 2025
Closed
@reaver585 reaver585 deleted the fix-tests-reloadability branch August 7, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aloubyansky aloubyansky aloubyansky approved these changes

Assignees

No one assigned

Labels

area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle kind/bugfix

Projects

None yet

Milestone

3.25.1

Development

Successfully merging this pull request may close these issues.

Gradle regression in tests when a module has a "sidecar" module

3 participants

@reaver585 @aloubyansky @gsmet