Skip to content

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Jul 24, 2025

It used to be more or less randomly defined depending on the order of execution of the build steps, which made it work until we started playing with the order for build reproducibility.

The patch is large because I moved the priorities to the runtime module so that I could use them in the recorder.

This issue was detected by the patch here: #49096 .

It used to be more or less randomly defined depending on the order of
execution of the build steps, which made it work until we started
playing with the order for build reproducibility.

The patch is large because I moved the priorities to the runtime module
so that I could use them in the recorder.
if (config.formAuthEnabled()) {
httpRouter.getValue()
.post(config.formPostLocation())
.order(-1 * SecurityHandlerPriorities.FORM_AUTHENTICATION)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually the only change of this PR, the rest is a refactoring to expose the constants in the runtime module.

Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The constants make sense, I thought about it before. As discussed, setting the form auth handler priority makes sense as we want it to run between auth and authz. It must run after the auth handler so setting -200 is out of question.

Copy link

quarkus-bot bot commented Jul 24, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit e3a8962.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/smallrye-reactive-messaging/deployment

io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector - History

  • Expecting actual: ["-3","-5","-6","-7","-8","-9","-10","-11"] to start with: ["-3", "-4", "-5", "-6"] - java.lang.AssertionError
java.lang.AssertionError: 

Expecting actual:
  ["-3","-5","-6","-7","-8","-9","-10","-11"]
to start with:
  ["-3", "-4", "-5", "-6"]

	at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:36)

@sberyozkin
Copy link
Member

Thanks @gsmet

@sberyozkin sberyozkin merged commit 369e31b into quarkusio:main Jul 24, 2025
57 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.26 - main milestone Jul 24, 2025
@gsmet gsmet modified the milestones: 3.26 - main, 3.25.1 Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants