-
Notifications
You must be signed in to change notification settings - Fork 3k
Set priority for form auth handler #49100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It used to be more or less randomly defined depending on the order of execution of the build steps, which made it work until we started playing with the order for build reproducibility. The patch is large because I moved the priorities to the runtime module so that I could use them in the recorder.
if (config.formAuthEnabled()) { | ||
httpRouter.getValue() | ||
.post(config.formPostLocation()) | ||
.order(-1 * SecurityHandlerPriorities.FORM_AUTHENTICATION) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually the only change of this PR, the rest is a refactoring to expose the constants in the runtime module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The constants make sense, I thought about it before. As discussed, setting the form auth handler priority makes sense as we want it to run between auth and authz. It must run after the auth handler so setting -200 is out of question.
Status for workflow
|
Thanks @gsmet |
It used to be more or less randomly defined depending on the order of execution of the build steps, which made it work until we started playing with the order for build reproducibility.
The patch is large because I moved the priorities to the runtime module so that I could use them in the recorder.
This issue was detected by the patch here: #49096 .