Support generating OpenShift manifests #4906
Conversation
iocanel
force-pushed
the
openshift-support
branch
from
82d3543 to
6cfe6bd
Compare
geoand
added
release/noteworthy-feature
triage/waiting-for-ci
|
|
||
| === Openshift support | ||
|
|
||
| To enable the genration of Openshift resources, you need to include Openshift in the target platforms: |
|
|
||
| [source] | ||
| ---- | ||
| kubernetes.deployment.target=kubernetes openshift |
There was a problem hiding this comment.
Is this whitespace separated or comma separated?
There was a problem hiding this comment.
We use comma's everywhere else, it should also use comma's for consistency.
Is there any reason why this is not using the Quarkus configuration model, but is doing its own config?
There was a problem hiding this comment.
Switched to comma separated.
Regarding the config, this pull request does get the config from the Quarkus ConfigProvider and converts it to the dekorate format. Does this anser your question @stuartwdouglas or you meant something else?
There was a problem hiding this comment.
@stuartwdouglas The configuration of this extension uses the pass-through strategy like the Kafka Streams does.
Originally this extension had the regular Quarkus configuration but it was too limiting so it was switched as part of #4308 (see this for more details)
...ubernetes/deployment/src/main/java/io/quarkus/kubernetes/deployment/KubernetesProcessor.java
Outdated
Show resolved
Hide resolved
geoand
removed
the
triage/waiting-for-ci
iocanel
force-pushed
the
openshift-support
branch
from
6cfe6bd to
12f8acb
Compare
| kubernetes.deployment.target=openshift | ||
| ---- | ||
|
|
||
| If you need to generate resources for both platforms (vanilla kubernetes and opesnhift), then you need to include both (space separated). |
There was a problem hiding this comment.
Sorry, I just saw that Openshift is spelled wrong here.
|
|
||
| [source] | ||
| ---- | ||
| kubernetes.deployment.target=kubernetes openshift |
There was a problem hiding this comment.
We use comma's everywhere else, it should also use comma's for consistency.
Is there any reason why this is not using the Quarkus configuration model, but is doing its own config?
iocanel
force-pushed
the
openshift-support
branch
from
12f8acb to
0dd4c29
Compare
|
Please make the title a bit more descriptive of what this PR is about as it will end up in the announcement email. Thanks! |
|
@stuartwdouglas Have your comments been addressed? |
gsmet
changed the title
4 participants
This pull request brings Openshift support to the kubernetes-extension.
The idea is that the user is able to select among:
using an option like:
kubernetes.deployment.target=openshiftin theapplication.properties.The pull request includes integration-test and docs and also a tiny fix to the existing integration tests.