-
Notifications
You must be signed in to change notification settings - Fork 3k
Compose Dev Services guide fixes #49037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compose Dev Services guide fixes #49037
Conversation
This comment has been minimized.
This comment has been minimized.
🙈 The PR is closed and the preview is expired. |
https://quarkus-pr-main-49037-preview.surge.sh/version/main/guides/compose-dev-services for quick look at the render |
Ozan is on PTO, so I removed him from the reviewers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had two minor suggestions, but these look like good improvements!
I also notice that we don't seem to have any tests using those config parameters so I couldn't validate them, but that's a problem for another day. :)
Co-authored-by: Holly Cummins <[email protected]>
Suggestions from code review are included |
Status for workflow
|
Compose Dev Services guide fixes
Interesting lines:
io.quarkus.devservices.compose.wait_for.logs.3: .\*Worker started.*
io.quarkus.devservices.compose.jdbc.parameters
is set, the parameters are added to the JDBC URL.io.quarkus.devservices.compose
prefix is the right one, see https://github.com/quarkusio/quarkus/blob/main/extensions/devservices/common/src/main/java/io/quarkus/devservices/common/Labels.java#L15