Skip to content

Conversation

rsvoboda
Copy link
Member

Compose Dev Services guide fixes

Interesting lines:

This comment has been minimized.

Copy link

github-actions bot commented Jul 22, 2025

🙈 The PR is closed and the preview is expired.

@rsvoboda
Copy link
Member Author

@rsvoboda rsvoboda removed the request for review from ozangunalp July 22, 2025 09:23
@rsvoboda
Copy link
Member Author

Ozan is on PTO, so I removed him from the reviewers

@gsmet gsmet requested a review from holly-cummins July 22, 2025 11:02
Copy link
Contributor

@holly-cummins holly-cummins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had two minor suggestions, but these look like good improvements!

I also notice that we don't seem to have any tests using those config parameters so I couldn't validate them, but that's a problem for another day. :)

@rsvoboda
Copy link
Member Author

Suggestions from code review are included

Copy link

quarkus-bot bot commented Jul 22, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 770a62d.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@geoand geoand merged commit c78dc37 into quarkusio:main Jul 22, 2025
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.26 - main milestone Jul 22, 2025
@gsmet gsmet modified the milestones: 3.26 - main, 3.24.5 Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants