Skip to content

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jul 16, 2025

This is a breaking change but I believe that it makes sense and the main goal is to mitigate the problem with Quarkus test profiles described in #48899.

@geoand
Copy link
Contributor

geoand commented Jul 16, 2025

Should there also be a doc entry for this?

@mkouba
Copy link
Contributor Author

mkouba commented Jul 16, 2025

Should there also be a doc entry for this?

It's documented in the javadoc 🤷. We don't have an entry per each feature in the docs.

However, it's a breaking change so we'll need to add a release note.

@geoand
Copy link
Contributor

geoand commented Jul 16, 2025

We don't have an entry per each feature in the docs

No one said we did... But what we do have is entries for stuff that may be useful in general

@mkouba
Copy link
Contributor Author

mkouba commented Jul 16, 2025

We don't have an entry per each feature in the docs

No one said we did... But what we do have is entries for stuff that may be useful in general

All the stuff may be useful in general but I get your point 😉.

@geoand
Copy link
Contributor

geoand commented Jul 16, 2025

👍🏽

This comment has been minimized.

This is a breaking change but I believe that it makes sense and the main
goal is to mitigate the problem with Quarkus test profiles described in
quarkusio#48899.
@mkouba mkouba force-pushed the component-config-source branch from 350a148 to 56f5850 Compare July 16, 2025 13:40
@mkouba
Copy link
Contributor Author

mkouba commented Jul 16, 2025

👍🏽

@geoand Done!

@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 16, 2025
@holly-cummins
Copy link
Contributor

Have we tried this with the reproducer for #48899 and friends? I think it's a good idea either way, I'm just curious. :)

@mkouba
Copy link
Contributor Author

mkouba commented Jul 16, 2025

Have we tried this with the reproducer for #48899 and friends? I think it's a good idea either way, I'm just curious. :)

Not yet, I will try that...

Copy link

quarkus-bot bot commented Jul 16, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 56f5850.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@mkouba
Copy link
Contributor Author

mkouba commented Jul 16, 2025

Have we tried this with the reproducer for #48899 and friends? I think it's a good idea either way, I'm just curious. :)

Not yet, I will try that...

@holly-cummins so I managed to run the reproducer (even though it's gradle 🙄) and this PR seems to fix the problem.

Copy link

github-actions bot commented Jul 16, 2025

🙈 The PR is closed and the preview is expired.

Copy link

quarkus-bot bot commented Jul 16, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 56f5850.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit fd70558 into quarkusio:main Jul 16, 2025
31 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.26 - main milestone Jul 16, 2025
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 16, 2025
@gsmet gsmet removed this from the 3.26 - main milestone Jul 22, 2025
@gsmet gsmet added this to the 3.25.0 milestone Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants