-
Notifications
You must be signed in to change notification settings - Fork 3k
QuarkusComponentTest: skip system config sources by default #48942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Should there also be a doc entry for this? |
It's documented in the javadoc 🤷. We don't have an entry per each feature in the docs. However, it's a breaking change so we'll need to add a release note. |
No one said we did... But what we do have is entries for stuff that may be useful in general |
All the stuff may be useful in general but I get your point 😉. |
👍🏽 |
This comment has been minimized.
This comment has been minimized.
This is a breaking change but I believe that it makes sense and the main goal is to mitigate the problem with Quarkus test profiles described in quarkusio#48899.
350a148
to
56f5850
Compare
@geoand Done! |
Have we tried this with the reproducer for #48899 and friends? I think it's a good idea either way, I'm just curious. :) |
Not yet, I will try that... |
Status for workflow
|
@holly-cummins so I managed to run the reproducer (even though it's gradle 🙄) and this PR seems to fix the problem. |
🙈 The PR is closed and the preview is expired. |
Status for workflow
|
This is a breaking change but I believe that it makes sense and the main goal is to mitigate the problem with Quarkus test profiles described in #48899.