-
Notifications
You must be signed in to change notification settings - Fork 3k
Simplify ConfigUtils#configBuilder #48926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
These are considered internal APIs, so I think we can break them and not go through a deprecation cycle. |
Status for workflow
|
Status | Name | Step | Failures | Logs | Raw logs | Build scan |
---|---|---|---|---|---|---|
⌛ | Native Tests - Messaging1 | Logs | Raw logs | 🚧 |
You can consult the Develocity build scans.
Flaky tests - Develocity
⚙️ JVM Integration Tests - JDK 17
📦 integration-tests/kafka-devservices
✖ io.quarkus.it.kafka.continuoustesting.DevServicesDevModeTest.testDevModeServiceDoesNotRestartContainersOnCodeChange
- History
New containers: [Container(command=sh -c 'while [ ! -f /work/run.sh ]; do sleep 0.1; done; sleep 0.1; /work/run.sh', created=1752584847, id=0c16debec37d5dbe329bb9b7cb831daf2612707383f544e37647a459de0121c1, image=quay.io/ogunalp/kafka-native:latest, imageId=sha256:99fa71388449ac7ff46bda7f6d645fb4435d9a21dce3d4dbcaedfc8a738afd6b, names=[/eager_meninsky], ports=[ContainerPort(ip=0.0.0.0, privatePort=9092, publicPort=32858, type=tcp), ContainerPort(ip=::, privatePort=9092, publicPort=32858, type=tcp)], labels={architecture=x86_64, build-date=2025-03-25T21:45:00Z, com.redhat.component=ubi9-micro-container, com.redhat.license_terms=https://www.redhat.com/en/about/red-hat-end-user-license-agreements\#UBI, description=Very small image which doesn't install the package manager., distribution-scope=public, io.buildah.version=1.39.0-dev, io.k8s.description=Very small image which doesn't install the package manager., io.k8s.display-name=Red Hat Universal Base Image 9 Micro, io.openshift.expose-s...
-org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError:
New containers: [Container(command=sh -c 'while [ ! -f /work/run.sh ]; do sleep 0.1; done; sleep 0.1; /work/run.sh', created=1752584847, id=0c16debec37d5dbe329bb9b7cb831daf2612707383f544e37647a459de0121c1, image=quay.io/ogunalp/kafka-native:latest, imageId=sha256:99fa71388449ac7ff46bda7f6d645fb4435d9a21dce3d4dbcaedfc8a738afd6b, names=[/eager_meninsky], ports=[ContainerPort(ip=0.0.0.0, privatePort=9092, publicPort=32858, type=tcp), ContainerPort(ip=::, privatePort=9092, publicPort=32858, type=tcp)], labels={architecture=x86_64, build-date=2025-03-25T21:45:00Z, com.redhat.component=ubi9-micro-container, com.redhat.license_terms=https://www.redhat.com/en/about/red-hat-end-user-license-agreements#UBI, description=Very small image which doesn't install the package manager., distribution-scope=public, io.buildah.version=1.39.0-dev, io.k8s.description=Very small image which doesn't install the package manager., io.k8s.display-name=Red Hat Universal Bas...
⚙️ JVM Integration Tests - JDK 21
📦 integration-tests/kafka-devservices
✖ io.quarkus.it.kafka.continuoustesting.DevServicesDevModeTest.testDevModeServiceDoesNotRestartContainersOnCodeChange
- History
New containers: [Container(command=sh -c 'while [ ! -f /work/run.sh ]; do sleep 0.1; done; sleep 0.1; /work/run.sh', created=1752584875, id=36ad867be5c3414991ccdfe23aa58920ab1319ffb7aeebafe45b66edb579bace, image=quay.io/ogunalp/kafka-native:latest, imageId=sha256:99fa71388449ac7ff46bda7f6d645fb4435d9a21dce3d4dbcaedfc8a738afd6b, names=[/gifted_williams], ports=[ContainerPort(ip=0.0.0.0, privatePort=9092, publicPort=32858, type=tcp), ContainerPort(ip=::, privatePort=9092, publicPort=32858, type=tcp)], labels={architecture=x86_64, build-date=2025-03-25T21:45:00Z, com.redhat.component=ubi9-micro-container, com.redhat.license_terms=https://www.redhat.com/en/about/red-hat-end-user-license-agreements\#UBI, description=Very small image which doesn't install the package manager., distribution-scope=public, io.buildah.version=1.39.0-dev, io.k8s.description=Very small image which doesn't install the package manager., io.k8s.display-name=Red Hat Universal Base Image 9 Micro, io.openshift.expose-...
-org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError:
New containers: [Container(command=sh -c 'while [ ! -f /work/run.sh ]; do sleep 0.1; done; sleep 0.1; /work/run.sh', created=1752584875, id=36ad867be5c3414991ccdfe23aa58920ab1319ffb7aeebafe45b66edb579bace, image=quay.io/ogunalp/kafka-native:latest, imageId=sha256:99fa71388449ac7ff46bda7f6d645fb4435d9a21dce3d4dbcaedfc8a738afd6b, names=[/gifted_williams], ports=[ContainerPort(ip=0.0.0.0, privatePort=9092, publicPort=32858, type=tcp), ContainerPort(ip=::, privatePort=9092, publicPort=32858, type=tcp)], labels={architecture=x86_64, build-date=2025-03-25T21:45:00Z, com.redhat.component=ubi9-micro-container, com.redhat.license_terms=https://www.redhat.com/en/about/red-hat-end-user-license-agreements#UBI, description=Very small image which doesn't install the package manager., distribution-scope=public, io.buildah.version=1.39.0-dev, io.k8s.description=Very small image which doesn't install the package manager., io.k8s.display-name=Red Hat Universal Ba...
The `initConfiguration` method was changed in quarkusio/quarkus#48926 For more information see the Quarkus PR
The
SmallRyeConfigBuilder#configBuilder
had parameters that are not meaningful anymore:LaunchMode
was used to addRuntimeOverrideConfigSource
, but the source is now added via a BuildStepio.quarkus.deployment.steps.ConfigGenerationBuildStep#runtimeOverrideConfig
, and the parameters combination inSmallRyeConfigBuilder#configBuilder
was not used anymore.boolean runtime
was used to addquarkus.uuid
, but this was moved sometime ago toio.quarkus.runtime.configuration.RuntimeConfigBuilder.UuidConfigSource
, and the builder is added automatically into the Runtime configboolean addDiscovered
was always set totrue
in every usageThese parameters were used before, and the move of the code to config builders made them superfluous.