-
Notifications
You must be signed in to change notification settings - Fork 3k
Clean up security fluent API configuration on shutdown #48908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up security fluent API configuration on shutdown #48908
Conversation
Thanks for your pull request! Your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
Status for workflow
|
🎊 PR Preview 7db6875 has been successfully built and deployed to https://quarkus-pr-main-48908-preview.surge.sh/version/main/guides/
|
Status for workflow
|
This refactoring comes from stuff I hit with the #48900 and it will make its review easier (so this PR is probably not vital). We have DEV mode tests and they are passing, but I think we need to add a shutdown task to cover all scenarios. The rest of refactoring is also something I have experienced during #48900, I'd like to propagate config from the recorder instead of querying the SR Config over and over again. The record is turned into a public class because we will need to expose at least one static method and I don't want to expose field accessors publicly.