Skip to content

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jul 11, 2025

This is a quick fix, but we should follow up with a fix that ensure that the recorder runs after the OTel recorder

Copy link

quarkus-bot bot commented Jul 11, 2025

/cc @brunobat (opentelemetry), @radcortez (opentelemetry)

Copy link
Contributor

@brunobat brunobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have a test replicating the original exception from quarkiverse/quarkus-langchain4j#1607

@geoand
Copy link
Contributor Author

geoand commented Jul 11, 2025

Fair enough

…abled` config value

This is a quick fix, but we should follow up with a fix that ensure that
the recorder runs after the OTel recorder

- Relates to: quarkiverse/quarkus-langchain4j#1607
@geoand
Copy link
Contributor Author

geoand commented Jul 11, 2025

Test added that faithfully reproduces the OTel related initialization steps that come into play with quarkiverse/quarkus-langchain4j#1607

Copy link
Contributor

@brunobat brunobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @geoand

@geoand
Copy link
Contributor Author

geoand commented Jul 11, 2025

🙏🏽

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 11, 2025
Copy link

quarkus-bot bot commented Jul 11, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 1d50b49.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Integration Tests - JDK 17

📦 integration-tests/kafka-devservices

io.quarkus.it.kafka.continuoustesting.DevServicesDevModeTest.testDevModeServiceDoesNotRestartContainersOnCodeChange - History

  • New containers: [Container(command=sh -c 'while [ ! -f /work/run.sh ]; do sleep 0.1; done; sleep 0.1; /work/run.sh', created=1752245616, id=475d118489a4d1c6955396c4e27e3981f6a4e7db414ee84193c049ed8ee2a17b, image=quay.io/ogunalp/kafka-native:latest, imageId=sha256:99fa71388449ac7ff46bda7f6d645fb4435d9a21dce3d4dbcaedfc8a738afd6b, names=[/hungry_kare], ports=[ContainerPort(ip=0.0.0.0, privatePort=9092, publicPort=32804, type=tcp), ContainerPort(ip=::, privatePort=9092, publicPort=32804, type=tcp)], labels={architecture=x86_64, build-date=2025-03-25T21:45:00Z, com.redhat.component=ubi9-micro-container, com.redhat.license_terms=https://www.redhat.com/en/about/red-hat-end-user-license-agreements\#UBI, description=Very small image which doesn't install the package manager., distribution-scope=public, io.buildah.version=1.39.0-dev, io.k8s.description=Very small image which doesn't install the package manager., io.k8s.display-name=Red Hat Universal Base Image 9 Micro, io.openshift.expose-serv... - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: 
New containers: [Container(command=sh -c 'while [ ! -f /work/run.sh ]; do sleep 0.1; done; sleep 0.1; /work/run.sh', created=1752245616, id=475d118489a4d1c6955396c4e27e3981f6a4e7db414ee84193c049ed8ee2a17b, image=quay.io/ogunalp/kafka-native:latest, imageId=sha256:99fa71388449ac7ff46bda7f6d645fb4435d9a21dce3d4dbcaedfc8a738afd6b, names=[/hungry_kare], ports=[ContainerPort(ip=0.0.0.0, privatePort=9092, publicPort=32804, type=tcp), ContainerPort(ip=::, privatePort=9092, publicPort=32804, type=tcp)], labels={architecture=x86_64, build-date=2025-03-25T21:45:00Z, com.redhat.component=ubi9-micro-container, com.redhat.license_terms=https://www.redhat.com/en/about/red-hat-end-user-license-agreements#UBI, description=Very small image which doesn't install the package manager., distribution-scope=public, io.buildah.version=1.39.0-dev, io.k8s.description=Very small image which doesn't install the package manager., io.k8s.display-name=Red Hat Universal Base I...

⚙️ JVM Integration Tests - JDK 21

📦 integration-tests/kafka-devservices

io.quarkus.it.kafka.continuoustesting.DevServicesDevModeTest.testDevModeServiceDoesNotRestartContainersOnCodeChange - History

  • New containers: [Container(command=sh -c 'while [ ! -f /work/run.sh ]; do sleep 0.1; done; sleep 0.1; /work/run.sh', created=1752245625, id=0c3b67e5ebfc11d2ac654ad47609e6905bd480ad4eab788dece923c112b587c4, image=quay.io/ogunalp/kafka-native:latest, imageId=sha256:99fa71388449ac7ff46bda7f6d645fb4435d9a21dce3d4dbcaedfc8a738afd6b, names=[/gallant_black], ports=[ContainerPort(ip=0.0.0.0, privatePort=9092, publicPort=32804, type=tcp), ContainerPort(ip=::, privatePort=9092, publicPort=32804, type=tcp)], labels={architecture=x86_64, build-date=2025-03-25T21:45:00Z, com.redhat.component=ubi9-micro-container, com.redhat.license_terms=https://www.redhat.com/en/about/red-hat-end-user-license-agreements\#UBI, description=Very small image which doesn't install the package manager., distribution-scope=public, io.buildah.version=1.39.0-dev, io.k8s.description=Very small image which doesn't install the package manager., io.k8s.display-name=Red Hat Universal Base Image 9 Micro, io.openshift.expose-se... - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: 
New containers: [Container(command=sh -c 'while [ ! -f /work/run.sh ]; do sleep 0.1; done; sleep 0.1; /work/run.sh', created=1752245625, id=0c3b67e5ebfc11d2ac654ad47609e6905bd480ad4eab788dece923c112b587c4, image=quay.io/ogunalp/kafka-native:latest, imageId=sha256:99fa71388449ac7ff46bda7f6d645fb4435d9a21dce3d4dbcaedfc8a738afd6b, names=[/gallant_black], ports=[ContainerPort(ip=0.0.0.0, privatePort=9092, publicPort=32804, type=tcp), ContainerPort(ip=::, privatePort=9092, publicPort=32804, type=tcp)], labels={architecture=x86_64, build-date=2025-03-25T21:45:00Z, com.redhat.component=ubi9-micro-container, com.redhat.license_terms=https://www.redhat.com/en/about/red-hat-end-user-license-agreements#UBI, description=Very small image which doesn't install the package manager., distribution-scope=public, io.buildah.version=1.39.0-dev, io.k8s.description=Very small image which doesn't install the package manager., io.k8s.display-name=Red Hat Universal Base...

@geoand geoand merged commit cf9bdea into quarkusio:main Jul 11, 2025
34 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.25 - main milestone Jul 11, 2025
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 11, 2025
@geoand geoand deleted the otel-init branch July 14, 2025 04:25
@gsmet gsmet modified the milestones: 3.25.0.CR1, 3.24.4 Jul 16, 2025
@jmartisk jmartisk modified the milestones: 3.24.4, 3.20.3 Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants